Skip to content

Check should warn when expected labels and annotations are confused #5718

Closed
@olix0r

Description

@olix0r

I just lost a lot of time to setting the mirror.linkerd.io/exported=true annotation, when it should have been a label.

It would be awesome if linkerd check could flag this sort of thing. Off the top of my head:

  • mirror.linkerd.io/exported should never be an annotation
  • config.linkerd.io/* should never be a label
  • linkerd.io/inject should never be a label

There may be others?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions