Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explain how to enable heapster on minikube #5710

Merged
merged 3 commits into from
Oct 2, 2017

Conversation

surajssd
Copy link
Member

@surajssd surajssd commented Oct 2, 2017

The docs which ask user to see if heapster is running,
this commit adds explanation of how you can enable heapster
on minikube Kubernetes cluster.


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 2, 2017
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Oct 2, 2017

Deploy preview ready!

Built with commit 7643e92

https://deploy-preview-5710--kubernetes-io-master-staging.netlify.com

@@ -23,6 +23,12 @@ A few of the steps on this page require that the
in your cluster. But if you don't have Heapster running, you can do most
of the steps, and it won't be a problem if you skip the Heapster steps.

If you are running minikube, to enable heapster run following command:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run following -> run the following
(Same thing in the other file)

@steveperry-53
Copy link
Contributor

@surajssd One comment. Otherwise LGTM.

The docs which ask user to see if heapster is running,
this commit adds explanation of how you can enable heapster
on minikube Kubernetes cluster.
@surajssd surajssd force-pushed the add-minikube-addons-help branch from f4288c6 to c267f14 Compare October 2, 2017 18:28
@surajssd
Copy link
Member Author

surajssd commented Oct 2, 2017

@steveperry-53 done!

@zacharysarah
Copy link
Contributor

@surajssd 👋 I made two tiny changes for wording. LGTM! :shipit:

@zacharysarah zacharysarah merged commit 650e84e into kubernetes:master Oct 2, 2017
cnef pushed a commit to ghostcloud-cn/kubernetes.github.io that referenced this pull request Oct 3, 2017
…hub.io into format-example-code

* 'master' of https://github.com/kubernetes/kubernetes.github.io:
  Remove broken link (kubernetes#5726)
  unified style (kubernetes#5725)
  Fixes in style and more on CDK (kubernetes#5292)
  Use code style for inline code and commands (kubernetes#5724)
  Fix link. (kubernetes#5723)
  Update distribute-credentials-secure.md (kubernetes#5169)
  Update documentation for vSphere Persistent Volume support (kubernetes#5465)
  Update _redirects
  Update scale-intro.html
  Update cluster-management.md (kubernetes#4980)
  ingress grammar/spelling updates (kubernetes#5721)
  Fix an incorrect flag in configure-upgrade-etcd.md (kubernetes#5304)
  Updated PR template for GH workaround (kubernetes#5719)
  separate commands from output (kubernetes#5718)
  explain how to enable heapster on minikube (kubernetes#5710)
@surajssd
Copy link
Member Author

surajssd commented Oct 3, 2017

@zacharysarah np 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants