Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect flag in configure-upgrade-etcd.md #5304

Merged
merged 1 commit into from
Oct 2, 2017

Conversation

shashidharatd
Copy link

@shashidharatd shashidharatd commented Sep 5, 2017

  1. There is no flag called --trust-ca-file in etcd and i presume it is --trusted-ca-file
  2. Using the same key and cert peer.key and peer.cert for both peer communication and client communication, confuses user. So differentiated it.

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.8 Features: set Milestone to 1.8 and Base Branch to release-1.8
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

NOTE: Please check the “Allow edits from maintainers” box (see image below) to
allow reviewers to fix problems on your patch and speed up the review process.

Please delete this note before submitting the pull request.

Allow edits from maintainers checkbox


This change is Reviewable

1. There is no flag called `--trust-ca-file` in etcd and i presume it is `--trusted-ca-file`
2. Using the same key and cert peer.key and peer.cert for both peer communication and client communication, confuses user. So differentiated it.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2017
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview ready!

Built with commit ce2bb04

https://deploy-preview-5304--kubernetes-io-master-staging.netlify.com

@zhangxiaoyu-zidif
Copy link
Contributor

@xiang90
could you do a tech review for this PR

@wojtek-t
Copy link
Member

wojtek-t commented Oct 2, 2017

/lgtm

@steveperry-53 steveperry-53 merged commit e319cf5 into kubernetes:master Oct 2, 2017
cnef pushed a commit to ghostcloud-cn/kubernetes.github.io that referenced this pull request Oct 3, 2017
…hub.io into format-example-code

* 'master' of https://github.com/kubernetes/kubernetes.github.io:
  Remove broken link (kubernetes#5726)
  unified style (kubernetes#5725)
  Fixes in style and more on CDK (kubernetes#5292)
  Use code style for inline code and commands (kubernetes#5724)
  Fix link. (kubernetes#5723)
  Update distribute-credentials-secure.md (kubernetes#5169)
  Update documentation for vSphere Persistent Volume support (kubernetes#5465)
  Update _redirects
  Update scale-intro.html
  Update cluster-management.md (kubernetes#4980)
  ingress grammar/spelling updates (kubernetes#5721)
  Fix an incorrect flag in configure-upgrade-etcd.md (kubernetes#5304)
  Updated PR template for GH workaround (kubernetes#5719)
  separate commands from output (kubernetes#5718)
  explain how to enable heapster on minikube (kubernetes#5710)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants