align EN training page styles with Docsy and fix its mobile UX#54826
Open
Caesarsage wants to merge 2 commits intokubernetes:mainfrom
Open
align EN training page styles with Docsy and fix its mobile UX#54826Caesarsage wants to merge 2 commits intokubernetes:mainfrom
Caesarsage wants to merge 2 commits intokubernetes:mainfrom
Conversation
k8s-ci-robot
added
the
area/web-development
k8s-ci-robot
added
language/en
Caesarsage
changed the title
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
lmktfy
reviewed
Mar 8, 2026
| cid: training | ||
| class: training | ||
| body_class: training | ||
| training_styles_migrated: true |
Member
There was a problem hiding this comment.
Suggested change
| training_styles_migrated: true | |
| # Once all localizations have migrated, we can drop the training_styles_migrated | |
| # field and simplify the CSS code. | |
| training_styles_migrated: true |
assets/scss/_k8s_training.scss
Outdated
|
|
||
| body.training section.call-to-action { | ||
| color: #ffffff; | ||
| background-color: #326ce5; |
assets/scss/_k8s_training.scss
Outdated
| } | ||
|
|
||
| body.training .button:hover { | ||
| background-color: #2357b0; |
assets/scss/_k8s_training.scss
Outdated
| } | ||
|
|
||
| body.training .lighter-gray-bg { | ||
| background-color: #f4f4f4; |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: f8539c3e7d79be9cd85d0632789439c4589704d3 |
lmktfy
reviewed
Mar 8, 2026
assets/scss/_k8s_training.scss
Outdated
| display: flex; | ||
| flex-grow: 1; | ||
| width: 18%; | ||
| background-color: #f9f9f9; |
lmktfy
reviewed
Mar 8, 2026
assets/scss/_k8s_training.scss
Outdated
| } | ||
|
|
||
| body.training .blue-bg { | ||
| background-color: #326ce5; |
lmktfy
reviewed
Mar 8, 2026
content/en/training/_index.html
Outdated
| <section> | ||
| <div class="main-section padded"> | ||
| <center> | ||
| <div class="training-center"> |
Member
There was a problem hiding this comment.
nit: we don't really need a class named training-center.
We can select based on eg body.training section > .main-section > … and not clash with other sections.
Contributor
Author
|
Thanks for the review, I will make the updates and make follow up localization PR |
k8s-ci-robot
removed
the
lgtm
Contributor
|
New changes are detected. LGTM label has been removed. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the English Training page to Docsy-aligned styling via the SCSS pipeline, while preserving legacy styling for other locales.
other locales stay unchanged.
Includes mobile alignment fixes for CTA and training partner sections.
new:
existing:
similar changes with the kubestronaut program section
Follow-up PRs will migrate each locale individually by enabling training_styles_migrated per locale.
related to #41171