Replace ui_search_placeholder with docsy provided ui_search
#50049
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/localization
k8s-ci-robot
added
language/hi
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Let's check that the localization folks don't have a concern about replacing two strings (in theory) with just one. Maybe some locales might one day want to set different things for the two strings. However, I suggest lazy consensus: if nobody objects within 14 days, we just proceed. |
|
/area web-development |
k8s-ci-robot
added
the
area/web-development
SayakMukhopadhyay
force-pushed
the
search-placeholder-name
branch
2 times, most recently
from
8e19c7c to
d68161e
Compare
|
/remove-language bn |
k8s-ci-robot
removed
language/bn
sftim
reviewed
Mar 24, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
SayakMukhopadhyay
changed the title
ui_search_placeholder with docsy provided ui_searchui_search_placeholder with docsy provided ui_search
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: ad31be920df48960f1007ed7e46ff42b888ed6bc
|
This was referenced Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the old translation placeholder key
ui_search_placeholderwith the newer placeholderui_search. This was only possible after #49643 was closed as without the changes in that PR, using the same placeholder key as Docsy would not override Docsy's value.But now, this change works.
This is a technical change and should not impact localisation but if needed, I can update this PR only for english and let other languages do their own updates.