-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unncessary i18nDir
from hugo.toml
#49643
base: main
Are you sure you want to change the base?
Remove unncessary i18nDir
from hugo.toml
#49643
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
i18nDir
from hugo-toml
i18nDir
from hugo.toml
Hmm, https://deploy-preview-49643--kubernetes-io-main-staging.netlify.app/bn/releases/ doesn't look happy does it? (compare https://kubernetes.io/bn/releases/) |
Nope, it seems like its not picking up the website defined localisation keys |
bdfbfe0
to
046baa1
Compare
This time, it seems to work. I removed all the symlinks and moved all the files from |
/hold |
e9c823e
to
178aab7
Compare
This PR is ready for review. It contains 55 file changes but most of them (52 files) are just the translations moving from The other 3 files include 2 files for removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How confident are you that README and contributor docs changes are included here, @SayakMukhopadhyay ?
@sftim They aren't. I was thinking about updating the README about the changes in here in a new PR, unless you would like to have them in this PR itself. |
bad5dc8
to
603cd4b
Compare
Description
This PR removes the unnecessary
i18nDir
property fromhugo.toml
.Issue
Closes: #49649