Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scheduler] Graduate NodeInclusionPolicy to GA #49927

Open
wants to merge 4 commits into
base: dev-1.33
Choose a base branch
from
Open

[Scheduler] Graduate NodeInclusionPolicy to GA #49927

wants to merge 4 commits into from
+9 −3

Conversation

kerthcet
Copy link
Member

Description

Issue

ref kubernetes/enhancements#3094

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/localization General issues or PRs related to localization area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes labels Feb 27, 2025
@k8s-ci-robot k8s-ci-robot added language/bn Issues or PRs related to Bengali language language/en Issues or PRs related to English language language/ja Issues or PRs related to Japanese language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/pl Issues or PRs related to Polish language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 27, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit ca6a227
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67e28cf7bc50680008b91082

@kerthcet kerthcet mentioned this pull request Feb 27, 2025
Open
12 tasks
@netlify Netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ca6a227
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67e28cf726e8a20008bc8c5c
😎 Deploy Preview https://deploy-preview-49927--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kerthcet kerthcet force-pushed the cleanup/upgrade-nodeinclusionpolicy-ga branch from e32c776 to 6d820b6 Compare February 27, 2025 06:27
@tengqm
Copy link
Contributor

tengqm commented Feb 27, 2025

oh no, something is wrong from your client side.
You are supposed to base your commit on dev-1.33 branch HEAD. and commit to that branch.

@sftim
Copy link
Contributor

sftim commented Feb 27, 2025

/label tide/merge-method-squash

Ideally: squash this to 1 (or small n) commits, and force push. Then we can remove that label.

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 27, 2025
@kerthcet
Copy link
Member Author

will fix this when doc ready.

@kerthcet
Copy link
Member Author

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Feb 27, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2025
@rayandas
Copy link
Member

rayandas commented Mar 25, 2025 •
edited
Loading

Hello @kerthcet 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th March 2025 18:00 PDT. Thank you!

@kerthcet kerthcet closed this Mar 25, 2025
@kerthcet kerthcet force-pushed the cleanup/upgrade-nodeinclusionpolicy-ga branch from 6d820b6 to edf6a64 Compare March 25, 2025 06:07
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 25, 2025
@kerthcet kerthcet reopened this Mar 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sftim for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sftim for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2025
@kerthcet
Graduate NodeInclusionPolicyInPodTopologySpread to GA
24ea875 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet kerthcet force-pushed the cleanup/upgrade-nodeinclusionpolicy-ga branch from 9a576da to 24ea875 Compare March 25, 2025 06:21
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2025
@kerthcet
Graduate NodeInclusionPolicyInPodTopologySpread to GA
8664a6a 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet kerthcet marked this pull request as ready for review March 25, 2025 06:25
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2025
@kerthcet
Copy link
Member Author

Hey @rayandas thanks for reminding, it's ready for review now.

@kerthcet
Copy link
Member Author

ping @kubernetes/sig-docs-en-owners

dipesh-rawat
dipesh-rawat reviewed Mar 25, 2025
View reviewed changes
...ference/command-line-tools-reference/feature-gates/NodeInclusionPolicyInPodTopologySpread.md
defaultValue: false
fromVersion: "1.25"
toVersion: "1.25"
- stage: beta
defaultValue: true
fromVersion: "1.26"
- stage: stable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toVersion should be added to the previous stage.

Suggested change
- stage: stable
toVersion: "1.32"
- stage: stable

Copy link
Member Author

@kerthcet kerthcet Mar 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it should be:

  - stage: beta
    defaultValue: true
    fromVersion: "1.26"
    toVersion: "1.32"
  - stage: stable
    defaultValue: true
    fromVersion: "1.33"

I missed the toVersion for beta level. for confirmation @dipesh-rawat

@dipesh-rawat
Copy link
Member

dipesh-rawat commented Mar 25, 2025 •
edited
Loading

/remove-language bn ja pl zh
/remove-area localization
/remove-area web-development

@k8s-ci-robot k8s-ci-robot removed area/localization General issues or PRs related to localization area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes language/bn Issues or PRs related to Bengali language language/ja Issues or PRs related to Japanese language language/pl Issues or PRs related to Polish language language/zh Issues or PRs related to Chinese language labels Mar 25, 2025
@kerthcet
Add toVersion for beta level
ca6a227 
Signed-off-by: kerthcet <kerthcet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@chenrui333 chenrui333 Awaiting requested review from chenrui333

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
SIG Scheduling
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kerthcet @tengqm @sftim @rayandas @k8s-ci-robot @dipesh-rawat