Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take taints/tolerations into consideration when calculating PodTopologySpread skew #3094

Open
9 of 12 tasks
kerthcet opened this issue Dec 22, 2021 · 59 comments
Open
9 of 12 tasks

Take taints/tolerations into consideration when calculating PodTopologySpread skew #3094

kerthcet opened this issue Dec 22, 2021 · 59 comments
Assignees
@kerthcet
Labels
sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@kerthcet
Copy link
Member

kerthcet commented Dec 22, 2021 •
edited
Loading

Enhancement Description
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 22, 2021
@kerthcet
Copy link
Member Author

/sig scheduling
/cc @Huang-Wei @alculquicondor @ahg-g

The milestone should still be discussed about.

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 22, 2021
@kerthcet
Copy link
Member Author

/assign

@kerthcet kerthcet mentioned this issue Jan 5, 2022
Merged
@ahg-g
Copy link
Member

ahg-g commented Jan 26, 2022

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 26, 2022
@kerthcet
Copy link
Member Author

kerthcet commented Jan 27, 2022 •
edited
Loading

Tip: When we time to graduate this to Beta, don't forget this advices. @kerthcet #3105 (comment)

@Priyankasaggu11929 Priyankasaggu11929 added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 27, 2022
@Priyankasaggu11929
Copy link
Member

Hello @kerthcet 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

For note, This enhancement is targeting for stage alpha for 1.24 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place & merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

For note, the status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@alculquicondor
Copy link
Member

Hi, is there any progress on the implementation PR?

@kerthcet
Copy link
Member Author

Hi, is there any progress on the implementation PR?

Yes, but I'm waiting for this kubernetes/kubernetes#107421 merged first for some potential conflicts.

@PI-Victor
Copy link
Member

Hi @kerthcet 👋 1.24 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@kerthcet kerthcet mentioned this issue Mar 3, 2022
Merged
@kerthcet
Copy link
Member Author

kerthcet commented Mar 4, 2022

Hi all, the api part of this kep has been finished in kubernetes/kubernetes#108492, please take a look if you guys have time.

@Priyankasaggu11929
Copy link
Member

Hello @kerthcet 👋

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

For note, the status of this enhancement is currently marked as at risk.

Kindly please let me know if I'm missing any open PRs other than the ones I linked above. Thank you so much!

@kerthcet
Copy link
Member Author

Thanks @Priyankasaggu11929 , no PR missed. I'll focus on this kep these days.

@kerthcet kerthcet mentioned this issue Mar 22, 2022
Merged
@gracenng
Copy link
Member

Hi, 1.24 Enhancements Lead here 👋. With code freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for code freeze is:

All PRs to the kubernetes/kubernetes repo have merged by the code freeze deadline
Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone Mar 30, 2022
@gracenng gracenng added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Mar 30, 2022
@kerthcet kerthcet mentioned this issue Mar 31, 2022
Closed
@kerthcet
Copy link
Member Author

kerthcet commented Apr 1, 2022

Exception was rejected and I'd like to merge this one to release 1.25 then.

@kerthcet kerthcet mentioned this issue Apr 3, 2022
Merged
@sanposhiho sanposhiho mentioned this issue May 29, 2022
Closed
@kerthcet kerthcet mentioned this issue Jun 8, 2022
Merged
@marosset
Copy link
Contributor

/remove-label lead-opted-in
/remove-label tracked/yes
/label tracked/no
/milestone clear

@k8s-ci-robot k8s-ci-robot added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Dec 14, 2022
@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Dec 14, 2022
@k8s-ci-robot k8s-ci-robot removed lead-opted-in Denotes that an issue has been opted in to a release tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Dec 14, 2022
@sanposhiho sanposhiho mentioned this issue Mar 4, 2023
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2023
@kerthcet
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2023
@Atharva-Shinde Atharva-Shinde removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 14, 2023
@sanposhiho sanposhiho mentioned this issue Oct 14, 2023
Open
4 tasks
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2024
@alculquicondor
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2024
@kerthcet
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 22, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 21, 2024
@kerthcet
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 23, 2024
@sanposhiho
Copy link
Member

@kerthcet Just noticed it's still beta by chance. I guess we can graduate it to stable?

@alculquicondor
Copy link
Member

Let me know if you don't have bandwidth and someone in my team can take it.

@kerthcet
Copy link
Member Author

Thanks for reminding, let me pack up my work. I'll update the KEP first.

@kerthcet kerthcet mentioned this issue Oct 9, 2024
Open
@alculquicondor
Copy link
Member

The enhancements freeze is tomorrow and this enhancement is not currently marked as tracked.

Since we have so much load from other KEPs, I'm thinking we should leave this one for the next release.

@kerthcet
Copy link
Member Author

Let's defer this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kerthcet kerthcet

Labels
sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
(Test board) Kubernetes 1.26 Enhancements Tracking
Status: No status
1.26 Enhancements Tracking
Status: Graduating
SIG Scheduling
Status: Needs Triage
Milestone
No milestone
Development

No branches or pull requests