Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Ukrainian localization #45371

Closed
wants to merge 36 commits into from
Closed

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Feb 27, 2024

Rolling up some changes made by @Andygol

…ions, stateless applications, and security. Update titles and weights for existing tutorial pages.
@Andygol
Copy link
Contributor

Andygol commented Feb 27, 2024

CLA check is passing; @Andygol can you confirm these commits are all your own work?

Yes. All this is my own work. You may find some of my announcements on LinkedIn regarding this (See https://www.linkedin.com/posts/andrii-holovin-b58201122_робота-над-перекладом-документації-kubernetes-activity-7166731616696967168-jL0Y/?utm_source=share&utm_medium=member_desktop).

@sftim
Copy link
Contributor Author

sftim commented Feb 27, 2024

/retitle Improve Ukrainian localization

@k8s-ci-robot k8s-ci-robot changed the title [WIP] Improve Ukrainian Improve Ukrainian localization Feb 27, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2024
@sftim
Copy link
Contributor Author

sftim commented Feb 27, 2024

I worry that these changes might be too large to review; however, I'll let reviewers for this localization decide.

@sftim
Copy link
Contributor Author

sftim commented Feb 27, 2024

@Andygol, I could split this out into four or five smaller PRs squashed down from the commits on this branch. If you're happy for me to do that, I'll open the PRs.

(because this is open source, anyone else is also welcome to do that)

Copy link
Contributor Author

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

This PR includes untranslated English content.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2024
@Arhell
Copy link
Member

Arhell commented Feb 27, 2024

I worry that these changes might be too large to review; however, I'll let reviewers for this localization decide.

Thank you, you are right, don't need to big of PR
It’s better to have a lot and not big ones, so that you can check and merge with the main branch.
It's my opinion

@Andygol
Copy link
Contributor

Andygol commented Feb 27, 2024

I could split this out into four or five smaller PRs

👍 It's fine.

In case we were doing similar work on some localization platform, the workflow would be much easier 😉

@MaxymVlasov
Copy link
Member

How the hell it should be reviewed in GH...

@MaxymVlasov
Copy link
Member

MaxymVlasov commented Feb 28, 2024

I propose blindly approving that and hope it does not contain some non-optimal stuff inside


<p><a href="https://www.appdirect.com/">AppDirect</a> provides an end-to-end commerce platform for cloud-based products and services. When Director of Software Development Pierre-Alexandre Lacerte began working there in 2014, the company had a monolith application deployed on a "tomcat infrastructure, and the whole release process was complex for what it should be," he says. "There were a lot of manual steps involved, with one engineer building a feature, then another team picking up the change. So you had bottlenecks in the pipeline to ship a feature to production." At the same time, the engineering team was growing, and the company realized it needed a better infrastructure to both support that growth and increase velocity.</p>

<h2>Solution</h2>
Copy link
Member

@MaxymVlasov MaxymVlasov Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. basically, there not translated 90% at least in a few files

@natalisucks
Copy link
Contributor

natalisucks commented Mar 30, 2024

I propose blindly approving that and hope it does not contain some non-optimal stuff inside

@MaxymVlasov Please do not do this. As already suggested in prior comments, this PR is too large to review and needs to be broken down into smaller PRs so that reviewers can have an easier job to do. "Blind approving", and suggesting to do so, undermines the trust that the Kubernetes project, and our SIG, have put into you as a reviewer and approver of this language.

@Andygol
Copy link
Contributor

Andygol commented Mar 30, 2024

@natalisucks, what is your thought about give it a fly as a pilot project, using one of the centralized translation management platforms to streamline the process?

re Discussions: #45209, #45438

@natalisucks
Copy link
Contributor

natalisucks commented Mar 30, 2024

@Andygol per greater discussion with the UK team in #45175, the next step regarding possible adoption of a translation platform, as I understood, was formulating a team to try and build a proof-of-concept for using this kind of platform, in the hope that several localization teams could weigh in and comment/help

@Andygol
Copy link
Contributor

Andygol commented Mar 30, 2024

@natalisucks I hope that in these efforts, SIG Docs will not stand aside and only observe, but will also take an active part in this project as its owner. 👭👬👫🧑‍🤝‍🧑🤝 🧑‍💼 #45209
I hope for fruitful and mutually beneficial cooperation on this project between the localization teams and SIG Docs.

@sftim
Copy link
Contributor Author

sftim commented Mar 31, 2024

@natalisucks I hope that in these efforts, SIG Docs will not stand aside and only observe, but will also take an active part in this project as its owner.

Hi. We're low on capacity for new initiatives, but that's not the same as zero capacity. I hope we can find folk to staff the efforts around experimenting with localization automation.
In the meantime, please do follow our norms around making changes to the live site; if you're stuck because of team capacity, let's surface that and work on how to recruit more team members who speak Ukrainian.

BTW: this PR probably should not merge. See #45371 (comment)

@sftim sftim marked this pull request as draft April 13, 2024 16:46
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2024
@natalisucks
Copy link
Contributor

My recommendation is to close this PR, unless the draft is still being used as a reference to break this down into smaller pieces of work

@sftim
Copy link
Contributor Author

sftim commented May 2, 2024

#45371 (comment)

Exactly that. There's such a big gap between main and the fork these are from that it will need a lot of work to bring in the changes, and this serves to remind me that it needs doing.

@natalisucks
Copy link
Contributor

Acknowledged, thanks @sftim!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sftim
Copy link
Contributor Author

sftim commented Aug 12, 2024

Ukrainian team are short on capacity to work on the Ukrainian part of https://k8s.io/

/close

@k8s-ci-robot
Copy link
Contributor

@sftim: Closed this PR.

In response to this:

Ukrainian team are short on capacity to work on the Ukrainian part of https://k8s.io/

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/uk Issues or PRs related to Ukrainian language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants