Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addons.md #45278

Closed
wants to merge 1 commit into from
Closed

Update addons.md #45278

wants to merge 1 commit into from

Conversation

techiescamp
Copy link

Removed Weave Net as it points to a 404 page.

Removed Weave Net as it points to a 404 page.
Copy link

linux-foundation-easycla bot commented Feb 22, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tengqm for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 22, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 22, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @techiescamp!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2024
Copy link

netlify bot commented Feb 22, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 020026b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65d6d035e3464e000818c094
😎 Deploy Preview https://deploy-preview-45278--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 22, 2024
@kundan2707
Copy link
Contributor

@techiescamp deleting a link is not a good idea. it is also good to check other links first then only delete.

@kundan2707
Copy link
Contributor

@stmcginnis
Copy link
Contributor

This is already being addressed in #45202. I think updating the link is a better option than just removing it.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jihoon-seo
Copy link
Member

The PR #45445 updated the link to point https://github.com/rajch/weave#using-weave-on-kubernetes instead.
I am going to close this PR.
If you have another suggestion, then please feel free to reopen this PR or open a new issue/PR.
/close

@k8s-ci-robot
Copy link
Contributor

@jihoon-seo: Closed this PR.

In response to this:

The PR #45445 updated the link to point https://github.com/rajch/weave#using-weave-on-kubernetes instead.
I am going to close this PR.
If you have another suggestion, then please feel free to reopen this PR or open a new issue/PR.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants