Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link for "Weave Net" documentation in "Installing Addons" page #45202

Closed
wants to merge 2 commits into from
Closed

Fix broken link for "Weave Net" documentation in "Installing Addons" page #45202

wants to merge 2 commits into from

Conversation

dev-johnn
Copy link
Contributor

Updated the link to "Weave Net" documentation to https://github.com/weaveworks/weave as suggested in #45201 (comment)

Closes #45201

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 19, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 19, 2024
@dev-johnn dev-johnn mentioned this pull request Feb 19, 2024
Closed
@dipesh-rawat
Copy link
Member

/retitle Fix broken link for "Weave Net" documentation in "Installing Addons" page
(Fixing the typo in title)

@k8s-ci-robot k8s-ci-robot changed the title Fixesd broken link for "Weave Net" documentation in "Installing Addons" pag Fix broken link for "Weave Net" documentation in "Installing Addons" page Feb 19, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 19, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 7f45847
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65d3875081036d00084f6c06
😎 Deploy Preview https://deploy-preview-45202--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Arhell
Arhell reviewed Feb 19, 2024
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dev-johnn @dipesh-rawat
Fix broken link
7f45847 
Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
vaibhav2107
vaibhav2107 approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@vaibhav2107 vaibhav2107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vaibhav2107
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f72b16de9b825f012694d52e4ebb39dc44b75162

@stmcginnis stmcginnis mentioned this pull request Feb 22, 2024
Closed
@kingdonb
Copy link
Contributor

kingdonb commented Mar 4, 2024 •
edited
Loading

I would suggest to not point at the weaveworks/weave repo, because it has not been maintained in several years, but instead to point at:

https://github.com/rajch/weave#using-weave-on-kubernetes

@rajch has taken up maintaining Weave Net in stealth mode for some time now, and the first official release was created in response to the Weave.works site going down. If there's any question about whose fork to follow, I worked at Weaveworks and I'm endorsing this one.

The weaveworks/weave repository does not have the one-liner in the README and that link will not be helpful to anyone who was expecting to find the easy-to-install one-liner Weave net kubectl apply command. (Edit: I see the link has already been changed in another PR, here: #45258 - perhaps we can start a new one.)

The updated Weave net one-liner is there, in the README of rajch's fork.

@kingdonb kingdonb mentioned this pull request Mar 4, 2024
Merged
@reylejano
Copy link
Member

Hmm, the updated link proposed in this PR links to a repo with the last commit is from 2 years ago
Weaveworks is shutting down, I propose to remove the line

reylejano
reylejano reviewed Mar 5, 2024
View reviewed changes
content/en/docs/concepts/cluster-administration/addons.md
@@ -82,7 +82,7 @@ installation instructions. The list does not try to be exhaustive.
* [Spiderpool](https://github.com/spidernet-io/spiderpool) is an underlay and RDMA
networking solution for Kubernetes. Spiderpool is supported on bare metal, virtual machines,
and public cloud environments.
* [Weave Net](https://www.weave.works/docs/net/latest/kubernetes/kube-addon/)
* [Weave Net](https://github.com/weaveworks/weave)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Weave Net](https://github.com/weaveworks/weave)

Since Weave Works is shutting down, I propose to remove the line

Copy link
Contributor

@kingdonb kingdonb Mar 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weave Net is open source, open source doesn't shut down like that.

I'd agree that we should remove the unmaintained thing if it was permanently unmaintained, but there is a maintainer publishing releases again, does he need to be backed by a company? (I think there is a company, but AFAIK @rajch is doing this personally, not as his company)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created:

Hopefully we can keep Weave Net in the guide 👍

@kingdonb kingdonb mentioned this pull request Mar 5, 2024
Merged
@dev-johnn dev-johnn deleted the fix-issue45201 branch March 10, 2024 18:27
Andygol pushed a commit to Andygol/k8s-website that referenced this pull request Mar 12, 2024
@kingdonb @Andygol
Update Weave Net link to supported fork
8cccfe9 
(rajch is the maintainer in charge of Weave Net now)

Ref: kubernetes#45202 (comment)

Signed-off-by: Kingdon B <yebyen@gmail.com>
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reylejano reylejano reylejano left review comments

@Arhell Arhell Arhell left review comments

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@kingdonb kingdonb kingdonb left review comments

@vaibhav2107 vaibhav2107 vaibhav2107 approved these changes

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@sftim sftim Awaiting requested review from sftim

Assignees

@vaibhav2107 vaibhav2107

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken link to "Weave Net" documentation in "Installing Addons" page
7 participants
@dev-johnn @dipesh-rawat @k8s-ci-robot @kingdonb @reylejano @Arhell @vaibhav2107