-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-1880 alpha: IPAddresses #37620
Merged
Merged
KEP-1880 alpha: IPAddresses #37620
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d7bc43e
Service CIDRs
aojea 6f914b6
KEP-1880 MultiCIDRServiceAllocator
aojea 35c0ef2
address comments and fix one bug
aojea 278215c
expand on the use of IPAddress
aojea a4a4d45
Update content/en/docs/reference/networking/virtual-ips.md
aojea dd44463
Update content/en/docs/reference/networking/virtual-ips.md
aojea f674460
enable v1alpha1 networking api group@
aojea 427ed08
Update content/en/docs/reference/networking/virtual-ips.md
aojea c4e4aec
Update content/en/docs/reference/networking/virtual-ips.md
aojea 5056816
Update content/en/docs/reference/networking/virtual-ips.md
aojea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you also need to enable an alpha API group for this to actually work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, good catch, it needs to enable networking.k8s.io/v1alpha1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is interesting, so if you only enable the feature gate it will fail to create any service