Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-1880 alpha: IPAddresses #37620

Merged
merged 10 commits into from
Apr 4, 2023
Merged

KEP-1880 alpha: IPAddresses #37620

merged 10 commits into from
Apr 4, 2023

Conversation

aojea
Copy link
Member

@aojea aojea commented Oct 31, 2022 •
edited
Loading

The KEP-1880 introduces two new types: IPAddress and ServiceCIDR.

KEP-1880 is meant to address the main problems with the IP allocation on Services.
During the implementation. phase, we realized the need to align the use of ServiceCIDR with the other KEP that is introducing multiple ClusterCIDR as a new type https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/2593-multiple-cluster-cidrs.
This is required because otherwise users can cause networking problems due to misconfigurations in their cluster.

Because of that, in this first iteration of the KEP-1880, only the new IPAddress object and its ClusterIP allocator is introduced.

kubernetes/enhancements#1880

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2022
@aojea aojea marked this pull request as draft October 31, 2022 11:14
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2022
@netlify
Copy link

netlify bot commented Oct 31, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ea849f0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/635fae05f6c06000073d56b3
😎 Deploy Preview https://deploy-preview-37620--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sftim
Copy link
Contributor

sftim commented Oct 31, 2022

@aojea could you write a description for this PR? I'm not sure what you intend it to be, other than that it's related to the KEP that you mentioned.

@aojea aojea changed the title Service CIDRs [WIP] Add placeholder blog post for KEP-1880 Nov 1, 2022
@aojea
Copy link
Member Author

aojea commented Nov 7, 2022

This will go for 1.27, it is not possible to me to deliver it this cycle

@aojea aojea closed this Nov 7, 2022
@aojea aojea reopened this Jan 25, 2023
@aojea aojea marked this pull request as ready for review January 25, 2023 15:07
@aojea aojea changed the base branch from main to dev-1.17 March 12, 2023 20:25
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2023
@aojea aojea changed the base branch from dev-1.17 to dev-1.27 March 12, 2023 20:26
@aojea aojea mentioned this pull request Mar 12, 2023
Open
8 tasks
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 12, 2023
@mickeyboxell
Copy link
Contributor

Hi @aojea 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review as soon as possible. 01:00 UTC Wednesday 22nd March 2023 / 17:00 PDT Tuesday 21st March 2023 is the official deadline.

This PR will need a doc review by Tuesday 4th April 2023 to get this into the release. Please reach out to required SIGs to get their review. Thank you!

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 21, 2023
aojea and others added 2 commits March 21, 2023 14:01
@aojea
Service CIDRs
d7bc43e
@aojea
KEP-1880 MultiCIDRServiceAllocator
6f914b6 
Signed-off-by: Antonio Ojea <aojea@google.com>
@aojea aojea changed the title [WIP] Add placeholder blog post for KEP-1880 KEP-1880 alpha: IPAddresses Mar 21, 2023
@k8s-ci-robot k8s-ci-robot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 21, 2023
@aojea
Copy link
Member Author

aojea commented Mar 21, 2023

/assign @sftim @thockin

sftim
sftim reviewed Apr 4, 2023
View reviewed changes
content/en/docs/reference/networking/virtual-ips.md Outdated
Comment on lines 302 to 306
If you enable the `MultiCIDRServiceAllocator`
[feature gate](/docs/reference/command-line-tools-reference/feature-gates/),
the control plane replaces the existing etcd allocator with a new one, using IPAddress
objects instead of an internal global allocation map. The ClusterIP address
associated to each `Service` will have a referenced IPAddress object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also need to enable an alpha API group for this to actually work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, good catch, it needs to enable networking.k8s.io/v1alpha1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is interesting, so if you only enable the feature gate it will fail to create any service

@aojea @tengqm
Update content/en/docs/reference/networking/virtual-ips.md
dd44463 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023
@netlify
Copy link

netlify bot commented Apr 4, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 5056816
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/642c29c1df4cbd00082cf17a

sftim
sftim reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b0d97455e245d55224d09a2f792de9455eb7ae55

@LukeMwila
Copy link

/approve

@aojea @sftim
Update content/en/docs/reference/networking/virtual-ips.md
427ed08 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim April 4, 2023 13:43
aojea and others added 2 commits April 4, 2023 15:44
@aojea @sftim
Update content/en/docs/reference/networking/virtual-ips.md
c4e4aec 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@aojea @sftim
Update content/en/docs/reference/networking/virtual-ips.md
5056816 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@sftim
Copy link
Contributor

sftim commented Apr 4, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9589bc6a212b8c8c25b5d8c5b6d660161a38dfbf

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LukeMwila, Rishit-dagli, sftim, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 44494e2 into kubernetes:dev-1.27 Apr 4, 2023
@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Apr 4, 2023
@aojea aojea mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@thockin thockin Awaiting requested review from thockin

@mickeyboxell mickeyboxell Awaiting requested review from mickeyboxell

@Rishit-dagli Rishit-dagli Awaiting requested review from Rishit-dagli

@sftim sftim Awaiting requested review from sftim

Assignees

@thockin thockin

@mickeyboxell mickeyboxell

@sftim sftim

@Rishit-dagli Rishit-dagli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.27
Development

Successfully merging this pull request may close these issues.
8 participants
@aojea @sftim @mickeyboxell @k8s-ci-robot @LukeMwila @tengqm @thockin @Rishit-dagli