Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc about how to get self subject attributes #35385

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Add doc about how to get self subject attributes #35385

merged 3 commits into from
Nov 28, 2022

Conversation

nabokihms
Copy link
Member

@nabokihms nabokihms commented Jul 25, 2022 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 25, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 25, 2022
@nabokihms nabokihms mentioned this pull request Jul 25, 2022
Closed
12 tasks
@netlify
Copy link

netlify bot commented Jul 25, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c080d9f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62df1f0b6adc1900098bfa1e
😎 Deploy Preview https://deploy-preview-35385--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@divya-mohan0209 divya-mohan0209 added this to the 1.25 milestone Jul 26, 2022
@divya-mohan0209
Copy link
Contributor

@nabokihms Hello there! I'm assuming this is for the 1.25 release. If yes, please could you resubmit the PR against the dev-1.25 branch instead of the main branch?

@nabokihms nabokihms changed the base branch from main to dev-1.25 July 29, 2022 12:27
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2022
@netlify
Copy link

netlify bot commented Jul 29, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit cb9dc5a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6383d752a9b7d900087315b7

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language labels Jul 29, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 29, 2022
@cathchu
Copy link
Contributor

cathchu commented Jul 29, 2022

Hey there 👋 @nabokihms , 1.25 Release Docs Shadow here!

Thanks for filing this placeholder. As a reminder, final docs PRs are due August 9th. Take a look at Documenting a release for additional information for the docs requirement for the release.

Thanks again!

@Sea-n
Copy link
Member

Sea-n commented Jul 31, 2022

/remove-area blog
/remove-language ja ko pt zh

@k8s-ci-robot k8s-ci-robot removed area/blog Issues or PRs related to the Kubernetes Blog subproject language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language labels Jul 31, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2022
@nabokihms
Copy link
Member Author

@sftim Thank you for your suggestions. I applied them all.

@sftim
Copy link
Contributor

sftim commented Oct 30, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7f4c1ea25b75b53c6a99c6e47417dda3de70c8f4

@liggitt
Copy link
Member

liggitt commented Nov 9, 2022

technical content lgtm

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2022
nabokihms and others added 2 commits November 10, 2022 12:52
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 10, 2022
krol3
krol3 approved these changes Nov 12, 2022
View reviewed changes
Copy link
Contributor

@krol3 krol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @mickeyboxell

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krol3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2022
sftim
sftim reviewed Nov 13, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm cancel

One thing to fix: the feature gate description looks truncated.

content/en/docs/reference/access-authn-authz/authentication.md Outdated Show resolved Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates.md Show resolved Hide resolved
@natalisucks
Copy link
Contributor

@nabokihms Hello from the SIG Auth triage meeting! There's a nit above from Tim that would be great to get fixed before we merge; I'm happy to be the one to re-add an LGTM when the above is looked over 👍 Thanks so much!

@nabokihms @sftim
Update content/en/docs/reference/access-authn-authz/authentication.md
cb9dc5a 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms
Copy link
Member Author

@sftim @natalisucks, sorry for the delay. I applied all suggestions.

@krol3
Copy link
Contributor

krol3 commented Nov 28, 2022

Hi @nabokihms, This PR needs a doc review by Mon Nov 28th to get this into the release. Please reach out to required SIGs to get their review. Thank you!
cc: @sftim

@natalisucks
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0571bdcfe2101adb12e561d8c7d98811d0c150dc

@k8s-ci-robot k8s-ci-robot merged commit f306471 into kubernetes:dev-1.26 Nov 28, 2022
@nabokihms nabokihms mentioned this pull request Mar 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@Sea-n Sea-n Sea-n left review comments

@sftim sftim sftim left review comments

@krol3 krol3 krol3 approved these changes

@cathchu cathchu Awaiting requested review from cathchu

Assignees

@natalisucks natalisucks

@sftim sftim

@cathchu cathchu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
Milestone
1.26
Development

Successfully merging this pull request may close these issues.
10 participants
@nabokihms @divya-mohan0209 @cathchu @Sea-n @reylejano @sftim @liggitt @k8s-ci-robot @natalisucks @krol3