Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3325: Promote SelfSubjectReview to Beta #39794

Merged
merged 1 commit into from
Mar 30, 2023
Merged

KEP-3325: Promote SelfSubjectReview to Beta #39794

merged 1 commit into from
Mar 30, 2023

Conversation

nabokihms
Copy link
Member

@nabokihms nabokihms commented Mar 5, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Mar 5, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 5, 2023
@nabokihms nabokihms changed the title Promote SelfSubjectReview to Beta KEP-3325: Promote SelfSubjectReview to Beta Mar 5, 2023
@netlify
Copy link

netlify bot commented Mar 5, 2023 •
edited
Loading

✅ Pull request preview available for checking

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6422f11394b40600c738f290
😎 Deploy Preview https://deploy-preview-39794--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sftim
Copy link
Contributor

sftim commented Mar 6, 2023

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Mar 6, 2023
sftim
sftim reviewed Mar 6, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid we can't accept the unrelated whitespace changes. Those will cause merge conflicts or force people to rebase when working on other changes.

You'll need to fix content/en/docs/reference/command-line-tools-reference/feature-gates.md @nabokihms so there are only a few lines that change.

@sftim
Copy link
Contributor

sftim commented Mar 6, 2023

/hold
until concern in #39794 (review) is addressed

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 6, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2023
@nabokihms
Copy link
Member Author

@sftim, sorry for this. My IDE autoformatted it.

@nabokihms
Copy link
Member Author

@sftim the code PR is merged. Do you need anything else to unhold this PR?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 12, 2023
@nabokihms nabokihms changed the base branch from main to dev-1.27 March 12, 2023 14:07
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2023
@nabokihms nabokihms requested a review from sftim March 12, 2023 14:08
@nabokihms
Promote SelfSubjectReview to Beta
bb14c6d 
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms nabokihms mentioned this pull request Mar 21, 2023
Closed
12 tasks
@liggitt
Copy link
Member

liggitt commented Mar 21, 2023

/retest
/hold cancel
technical content lgtm (for sig-auth)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2023
@sftim
Copy link
Contributor

sftim commented Mar 21, 2023

/hold cancel

@liggitt
Copy link
Member

liggitt commented Mar 21, 2023

/assign

@liggitt
Copy link
Member

liggitt commented Mar 21, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fc30f4742acfc0092c9f81d5f82124fdf8e5ea47

@tengqm
Copy link
Contributor

tengqm commented Mar 22, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
@sftim
Copy link
Contributor

sftim commented Mar 28, 2023

@nabokihms please consider updating the kubectl auth whoami command as well; it's strongly related.

@nabokihms
Copy link
Member Author

I will take a look today.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2023
@netlify
Copy link

netlify bot commented Mar 30, 2023

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit bb14c6d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6425d44a4cd75900084b96d7

@nabokihms nabokihms requested a review from sftim March 30, 2023 18:29
@sftim
Copy link
Contributor

sftim commented Mar 30, 2023

Thanks
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8494eebec28b60fec94665e4eefd40cf4e0663e3

@k8s-ci-robot k8s-ci-robot merged commit b842957 into kubernetes:dev-1.27 Mar 30, 2023
@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@liggitt liggitt Awaiting requested review from liggitt

@sftim sftim Awaiting requested review from sftim

Assignees

@liggitt liggitt

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
Milestone
1.27
Development

Successfully merging this pull request may close these issues.
5 participants
@nabokihms @sftim @liggitt @k8s-ci-robot @tengqm