Clarify topology aware hints needs explicit enabling #32413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
sig/docs
sftim
reviewed
Mar 22, 2022
| costs, or to improve network performance. | ||
|
|
||
| {{< note >}} | ||
| The "topology-aware hints" feature is at Beta stage and it is NOT enabled |
There was a problem hiding this comment.
style nit:
Suggested change
| The "topology-aware hints" feature is at Beta stage and it is NOT enabled | |
| The "topology-aware hints" feature is at Beta stage and it is **not** enabled |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 3dad0a6216ad1a09230948984c8cd5aa9150e86b
|
|
✅ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: 09ae2ba 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6239adc12f94830007a07660 😎 Browse the preview: https://deploy-preview-32413--kubernetes-io-main-staging.netlify.app |
tengqm
force-pushed
the
topology-aware-hints
branch
from
071465d to
09ae2ba
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 6923db61c8b4e4eaa9eac8b0ae3cbac1ef155542
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue that is raised when updating the TopologyAwareHints feature gate. The said feature gate is introduced as Beta in 1.23, but it is defaulted to false. This might be a surprise to users.
In 1.24, the gate is "back to normal", defaulted to true as a Beta feature (see #32361).