Skip to content

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Mar 19, 2022

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Mar 19, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 19, 2022
@netlify
Copy link

netlify bot commented Mar 19, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: aa68dec

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62367d5b8244990008c9b341

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Mar 19, 2022
@k8s-ci-robot k8s-ci-robot requested review from jimangel and sftim March 19, 2022 01:55
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 19, 2022
@sftim
Copy link
Contributor

sftim commented Mar 19, 2022

/retitle Mark that TopologyAwareHints feature is default on in 1.24

@k8s-ci-robot k8s-ci-robot changed the title TopologyAwareHints feature is default on in 1.24 Mark that TopologyAwareHints feature is default on in 1.24 Mar 19, 2022
@tengqm tengqm force-pushed the topologyawarehints-on branch from 5bec0e9 to aa68dec Compare March 20, 2022 01:03
@reylejano
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 29b21e80a0a319ebe35c87c1b9b83329dc6594ae

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit b91618b into kubernetes:dev-1.24 Mar 25, 2022
@tengqm tengqm deleted the topologyawarehints-on branch March 26, 2022 00:05
@mehabhalodiya
Copy link
Contributor

enhancement ref: kubernetes/enhancements#2433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants