Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate workloads/controllers/ttlafterfinished.md in Korean. #17241

Merged
merged 6 commits into from
Oct 31, 2019
Merged

Translate workloads/controllers/ttlafterfinished.md in Korean. #17241

merged 6 commits into from
Oct 31, 2019

Conversation

ysyukr
Copy link
Member

@ysyukr ysyukr commented Oct 28, 2019

문서를 번역했습니다. 리뷰 부탁드립니다.

from #16911
/language ko

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 28, 2019
@netlify
Copy link

netlify bot commented Oct 28, 2019

Deploy preview for k8s-dev-ko ready!

Built with commit 01f2c30

https://deploy-preview-17241--k8s-dev-ko.netlify.com

@gochist
Copy link
Member

gochist commented Oct 28, 2019

/assign @seokho-son

Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysyukr 감사합니다 👍
리뷰 의견 남겼습니다. 참고하셔서 업데이트 부탁드립니다 ~~

ysyukr and others added 2 commits October 29, 2019 17:54
Co-Authored-By: Seokho Son <shsongist@gmail.com>
Co-Authored-By: Seokho Son <shsongist@gmail.com>
@ysyukr
Copy link
Member Author

ysyukr commented Oct 29, 2019

@seokho-son 리뷰 감사합니다. 제안해주신 내용 확인해서 업데이트 진행했습니다 :)

@seokho-son
Copy link
Member

@ysyukr Thank you !
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit b749cbf into kubernetes:dev-1.16-ko.4 Oct 31, 2019
seokho-son added a commit that referenced this pull request Nov 8, 2019
* Translate workloads/controllers/ttlafterfinished.md in Korean. (#17241)
* Update Korean l10n guide (#17402)
* Translate tasks/manage-kubernetes-objects/kustomization in Korean (#17225)
* Update file outdated korean docs in dev-1.16-ko.4 (#17235)
* Translate concepts/workloads/pods/ephemeral-containers.md in Korean. (#16630)

Co-Authored-By: Yuk, Yongsu <ysyukr@gmail.com>
Co-Authored-By: Cheolgu Kim <lapee79@gmail.com>
Co-Authored-By: June Yi <gochist@gmail.com>
Co-Authored-By: Seokho Son <shsongist@gmail.com>
k8s-ci-robot pushed a commit that referenced this pull request Nov 8, 2019
* Translate workloads/controllers/ttlafterfinished.md in Korean. (#17241)
* Update Korean l10n guide (#17402)
* Translate tasks/manage-kubernetes-objects/kustomization in Korean (#17225)
* Update file outdated korean docs in dev-1.16-ko.4 (#17235)
* Translate concepts/workloads/pods/ephemeral-containers.md in Korean. (#16630)

Co-Authored-By: Yuk, Yongsu <ysyukr@gmail.com>
Co-Authored-By: Cheolgu Kim <lapee79@gmail.com>
Co-Authored-By: June Yi <gochist@gmail.com>
Co-Authored-By: Seokho Son <shsongist@gmail.com>
@ysyukr ysyukr deleted the translate-16911 branch November 11, 2019 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants