Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup OWNERS in k/website, add milestone team #13287

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Cleanup OWNERS in k/website, add milestone team #13287

merged 1 commit into from
Mar 20, 2019

Conversation

zacharysarah
Copy link
Contributor

@zacharysarah zacharysarah commented Mar 19, 2019

This PR removes stale, unused teams in k/website and cleans up team membership.

Most of the info defined in OWNERS_ALIASES is severely outdated, and also not used for automation in this repo. The exception is sig-cluster-lifecycle-*, who actively curate their membership. (#9497)

EDIT: This PR originally added a milestone team to enable the /milestone command, but that's not necessary as per @nikhita, and would add an unnecessary layer of cruft (which this PR ostensibly is all about removing).

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 19, 2019
@netlify
Copy link

netlify bot commented Mar 19, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 06c0fa7

https://deploy-preview-13287--kubernetes-io-master-staging.netlify.com

@zacharysarah
Copy link
Contributor Author

/assign @Bradamant3 @zparnold

@zacharysarah zacharysarah changed the title [WIP] Cleanup OWNERS in k/website Cleanup OWNERS in k/website, add milestone team Mar 19, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2019
Explicitly list membership

Remove milestone team
@cody-clark
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cody-clark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5238498 into kubernetes:master Mar 20, 2019
@zacharysarah zacharysarah deleted the cleanup-teams branch March 20, 2019 22:26
claudiajkang pushed a commit that referenced this pull request Apr 2, 2019
Explicitly list membership

Remove milestone team
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants