-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add milestone team, clean up teams in general #628
Add milestone team, clean up teams in general #628
Conversation
/assign @nikhita |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, with the possible exception of a stray whitespace character toward the top of the file. Not adding any commands because it looks like it's not ready to merge (conflicts, tests not passing), but content seems good.
09fe65d
to
4c3a1fe
Compare
de93a95
to
ef0a572
Compare
…rysarah/org into add-website-milestone-team
website-milestone-maintainers: | ||
description: Contributors who can use `/milestone` in the website repo. Defined in https://github.com/kubernetes/org/blob/master/config/kubernetes/sig-docs/teams.yaml. | ||
members: | ||
- sig-docs-en-owners |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, teams can't be nested like this 😬
You'll either need to add this as a "parent team" to the sig-docs-*
teams like https://github.com/kubernetes/org/blob/master/config/kubernetes/sig-cloud-provider/teams.yaml#L18 or expand all teams and list out members individually.
While the latter seems cumbersome, I'd mostly suggest that because GitHub says that (ref https://help.github.com/en/articles/about-teams#nested-teams):
Child teams inherit the parent's access permissions, simplifying permissions management for large groups. Members of child teams also receive notifications when the parent team is @mentioned, simplifying communication with multiple groups of people.
I'm not sure if this is a cause for concern here but it may lead to unexpected things with respect to permissions in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood! Listing folks out will be cumbersome for obvious reasons, but better safe than sorry.
Explicitly list team members Sort maintainers lists
54ef14f
to
d521d7c
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chenopis, zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@nikhita 👋 This PR is green now and ready to merge. 💚 |
members: | ||
- chenrui333 | ||
- idealhack | ||
- pigletfly | ||
privacy: closed | ||
website-milestone-maintainers: | ||
description: Contributors who can use `/milestone` in the website repo. Defined in https://github.com/kubernetes/org/blob/master/config/kubernetes/sig-docs/teams.yaml. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the link points to this file, maybe we drop it? :)
sig-docs-en-owners: | ||
description: English content admins | ||
maintainers: | ||
- bradamant3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zacharysarah added a couple of comments, but this looks good to go otherwise! |
Oh and one last thing...could you also sqaush the commits? :) |
For kubernetes/test-infra#11687 (comment).
This PR specifies who can use
/milestone
in the website repo.Membership in this team requires an entry in a
sig-docs-**-owners
alias for a localization project in k/website. (See kubernetes/website#13287) Note thatwebsite-milestone-maintainers
imports membership by reference to language owner groups.This PR also updates sig-docs team membership based on
k/website/OWNERS_ALIASES
.