Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add milestone team, clean up teams in general #628

Closed

Conversation

zacharysarah
Copy link

@zacharysarah zacharysarah commented Mar 19, 2019

For kubernetes/test-infra#11687 (comment).

This PR specifies who can use /milestone in the website repo.

Membership in this team requires an entry in a sig-docs-**-owners alias for a localization project in k/website. (See kubernetes/website#13287) Note that website-milestone-maintainers imports membership by reference to language owner groups.

This PR also updates sig-docs team membership based on k/website/OWNERS_ALIASES.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 19, 2019
@zacharysarah
Copy link
Author

/assign @nikhita

Copy link

@Bradamant3 Bradamant3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, with the possible exception of a stray whitespace character toward the top of the file. Not adding any commands because it looks like it's not ready to merge (conflicts, tests not passing), but content seems good.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2019
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 19, 2019
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2019
website-milestone-maintainers:
description: Contributors who can use `/milestone` in the website repo. Defined in https://github.com/kubernetes/org/blob/master/config/kubernetes/sig-docs/teams.yaml.
members:
- sig-docs-en-owners
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, teams can't be nested like this 😬

You'll either need to add this as a "parent team" to the sig-docs-* teams like https://github.com/kubernetes/org/blob/master/config/kubernetes/sig-cloud-provider/teams.yaml#L18 or expand all teams and list out members individually.

While the latter seems cumbersome, I'd mostly suggest that because GitHub says that (ref https://help.github.com/en/articles/about-teams#nested-teams):

Child teams inherit the parent's access permissions, simplifying permissions management for large groups. Members of child teams also receive notifications when the parent team is @mentioned, simplifying communication with multiple groups of people.

I'm not sure if this is a cause for concern here but it may lead to unexpected things with respect to permissions in the future.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood! Listing folks out will be cumbersome for obvious reasons, but better safe than sorry.

Explicitly list team members

Sort maintainers lists
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenopis, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zacharysarah
Copy link
Author

@nikhita 👋 This PR is green now and ready to merge. 💚

members:
- chenrui333
- idealhack
- pigletfly
privacy: closed
website-milestone-maintainers:
description: Contributors who can use `/milestone` in the website repo. Defined in https://github.com/kubernetes/org/blob/master/config/kubernetes/sig-docs/teams.yaml.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the link points to this file, maybe we drop it? :)

sig-docs-en-owners:
description: English content admins
maintainers:
- bradamant3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All users need to defined as members instead of maintainers. Ref: #563

I have a PR to add a test for it #592, so this should be caught earlier in the future. 😬

@nikhita
Copy link
Member

nikhita commented Mar 21, 2019

@zacharysarah added a couple of comments, but this looks good to go otherwise!

@nikhita
Copy link
Member

nikhita commented Mar 21, 2019

Oh and one last thing...could you also sqaush the commits? :)

@zacharysarah
Copy link
Author

zacharysarah commented Mar 22, 2019

@nikhita Two of the commits in this PR are merge commits and won't rebase properly for squashing. I'm going to close this PR and start fresh with a new one.

UPDATE: Rebooted as #644.

@zacharysarah zacharysarah deleted the add-website-milestone-team branch March 22, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants