-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis - Checkout the right K8s release and align on go version #13122
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit d86fd1e https://deploy-preview-13122--kubernetes-io-master-staging.netlify.com |
Deploy preview for kubernetes-io-master-staging ready! Built with commit ba2890f https://deploy-preview-13122--kubernetes-io-master-staging.netlify.com |
cc @tengqm -- Qiming, do you have ideas here? Seems related to fixes to the examples tests you've provided in the past. (See also #sig-docs Slack) |
Every release of k8s introduces some changes and/or refactoring that lead to test failure. The failure of this PR is expected and should be fixed. Need to examine the upstream code base to find out where the testing facility has been relocated. |
Hello. After some searching, here is one package change: |
@tengqm, I have not looked at the tests closely. Is this run for every build or only when an example changes. This area could use some documentation 👍 |
@kbarnard10 is run on every build i think - see https://github.com/kubernetes/website/blob/master/.travis.yml#L23-L26 |
@kbhawkey The test cases use to run on every build, before #11555 was merged. For all branches we maintain, we are supposed to use the correct version of go-lang and the correct version of upstream code for checking. This ensures that the examples we provide are usable for the version against which we have checked. I agree we should document this -- every time we create a |
Thanks for the explanation @tengqm.
|
@tengqm i see you created a new PR in which case i'll close this PR in favour of yours |
Fixes #13121
cc @zacharysarah as per our last night slack chat