Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache example_test results with travis #11555

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

GuessWhoSamFoo
Copy link
Contributor

Since example_test.go does not change frequently, caching the tests can bring the CI times from 50s to a few seconds if there are no changes.

Signed-off-by: GuessWhoSamFoo sfoohei@gmail.com

Signed-off-by: GuessWhoSamFoo <sfoohei@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 57c6c3a

https://deploy-preview-11555--kubernetes-io-master-staging.netlify.com

@tengqm
Copy link
Contributor

tengqm commented Dec 6, 2018

the pro is obvious: shorter turnaround;
the con is subtle: when upstream code changes, the existing samples may break thus need fixes;
doubt: how can we explicitly request a check when new examples are added?

@bradtopol
Copy link
Contributor

This looks like there are some issues that would need to be addressed before this is viable. Im going to ask @zacharysarah to keep an eye on this.

@zacharysarah
Copy link
Contributor

@GuessWhoSamFoo 👋 Thanks for your patience, I'm finally back from vacation.

I like the idea, but @tengqm's concern is a valid one. Any feedback on how to check for upstream test changes?

@zacharysarah zacharysarah added Docs LGTM sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 28, 2019
@zparnold
Copy link
Member

zparnold commented Feb 13, 2019

From: https://golang.org/cmd/go/#hdr-Build_and_test_caching

The build cache correctly accounts for changes to Go source files, compilers, compiler options, and so on: cleaning the cache explicitly should not be necessary in typical use.

@zacharysarah I think this is fine, if the file changes, the cache is invalidated

@zparnold
Copy link
Member

/lgtm
(I'll wait on @zacharysarah for /approveal)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2019
@zacharysarah
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit c319d0c into kubernetes:master Mar 11, 2019
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
Signed-off-by: GuessWhoSamFoo <sfoohei@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants