-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache example_test results with travis #11555
Cache example_test results with travis #11555
Conversation
Signed-off-by: GuessWhoSamFoo <sfoohei@gmail.com>
Deploy preview for kubernetes-io-master-staging ready! Built with commit 57c6c3a https://deploy-preview-11555--kubernetes-io-master-staging.netlify.com |
the pro is obvious: shorter turnaround; |
This looks like there are some issues that would need to be addressed before this is viable. Im going to ask @zacharysarah to keep an eye on this. |
@GuessWhoSamFoo 👋 Thanks for your patience, I'm finally back from vacation. I like the idea, but @tengqm's concern is a valid one. Any feedback on how to check for upstream test changes? |
From: https://golang.org/cmd/go/#hdr-Build_and_test_caching
@zacharysarah I think this is fine, if the file changes, the cache is invalidated |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: GuessWhoSamFoo <sfoohei@gmail.com>
Since example_test.go does not change frequently, caching the tests can bring the CI times from 50s to a few seconds if there are no changes.
Signed-off-by: GuessWhoSamFoo sfoohei@gmail.com