Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/jobs/kubernetes/sig-aws/eks: use latest "kubekins-e2e" image #10060

Closed
wants to merge 1 commit into from
Closed

config/jobs/kubernetes/sig-aws/eks: use latest "kubekins-e2e" image #10060

wants to merge 1 commit into from

Conversation

gyuho
Copy link
Member

@gyuho gyuho commented Nov 7, 2018

Seems like we were too late to include #10040 in #10033.

Otherwise, until the next image bump, EKS jobs will
keep seeing 'unknown deployment strategy "eks"', or
use the old kubetest, which does not download "aws-k8s-tester" binary.

We will use the stable "kubekins-e2e" image once it includes the
latest EKS plugin changes.

/cc @krzyzacy @BenTheElder

How often do we build gcr.io/k8s-testimages/kubekins-e2e:latest-master? Hope this can pick up the latest change to EKS kubetest plugin.

We're too late to include
#10040 in
#10033.

Otherwise, until the next image bump, EKS jobs will
keep seeing 'unknown deployment strategy "eks"', or
use the old kubetest, which does not download "aws-k8s-tester" binary.

We will use the stable "kubekins-e2e" image once it includes the
latest EKS plugin changes.

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config labels Nov 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyuho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2018
@krzyzacy
Copy link
Member

krzyzacy commented Nov 7, 2018

I can build a new image for you tomorrow, generally you don't want to use latest tag as it can have breaking changes before we canary it out :-)

@gyuho
Copy link
Member Author

gyuho commented Nov 7, 2018

@krzyzacy

I can build a new image for you tomorrow

Sounds awesome. Thanks!

We will just wait then.

@gyuho gyuho closed this Nov 7, 2018
@k8s-ci-robot
Copy link
Contributor

@gyuho: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-test-infra-bazel d984bde link /test pull-test-infra-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@krzyzacy
Copy link
Member

krzyzacy commented Nov 7, 2018

latest-master: digest: sha256:5b94721de25aaf16f239f4eda7684ac7f5c9a31796f126558d92df57ae339410 size: 4937
Pushed gcr.io/k8s-testimages/kubekins-e2e with :latest-master and :v20181106-9fd606c0b-master tags

feel free to consume that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants