kubetest/eks: download "aws-k8s-tester" binary, use upstream image

[gyuho]

• awstester has been renamed to aws-k8s-tester
• Switch back to upstream gcr.io/k8s-testimages/kubekins-e2e image, let kubetest automatically download binaries
• Update aws-k8s-tester dependency to latest

ref. #9814

/cc @krzyzacy @d-nishi

[krzyzacy]

at high level: why download the binary at runtime? this can potentially make your tests flaky and waste of network resources?

[gyuho]

@krzyzacy @BenTheElder

I think downloading on demand is more maintainable.

If we build our own image with aws-k8s-tester, we need keep it in sync with gcr.io/k8s-testimages/kubekins-e2e (whenever changes happen in the upstream). On the other hand, if we download binaries on test runs, we just update the download URL whenever we release new features to our plugin, and the base test image will always be up-to-date.

I am trying to do something similar to:

test-infra/kubetest/kops.go

Lines 294 to 298 in 7b85b7b

	// Download kops from kopsBaseURL if kopsPath is not set
	if *kopsPath == "" {
	if *kopsBaseURL == "" {
	return nil, errors.New("--kops or --kops-base-url must be set")
	}

[d-nishi]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 28233a68b584814fff613b2c5f510c45ef673b2a

[BenTheElder]

Network resources shouldn't be an issue, downloading can be flakier though is worth noting. Seems like a reasonable route to me, if they experience too many related flakes it can always be revisited.

[krzyzacy]

do we care about cleaning up those downloaded binaries?

[gyuho]

@krzyzacy Just added :)

[krzyzacy]

/lgtm
/hold

Maybe as a follow up, add some comments/docs on all the envs, if you are expect other people to use your deployer.
(feel free to /hold cancel)

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: c789810830cb6b2cf8e72f5d36fa20f4fbd963a4

[gyuho]

/hold cancel

[gyuho]

/hold

[gyuho]

/hold cancel

[gyuho]

@krzyzacy @d-nishi PTAL. Documented all environmental variables.

[BenTheElder]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 0adf35006dab4c6bd10ab61532561b1070777e4c

[d-nishi]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, d-nishi, gyuho, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [BenTheElder,krzyzacy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@gyuho: Updated the job-config configmap using the following files:

• key k8s-aws-eks-1.10.yaml using file config/jobs/kubernetes/sig-aws/eks/k8s-aws-eks-1.10.yaml

In response to this:

• awstester has been renamed to aws-k8s-tester
• Switch back to upstream gcr.io/k8s-testimages/kubekins-e2e image, let kubetest automatically download binaries
• Update aws-k8s-tester dependency to latest

ref. #9814

/cc @krzyzacy @d-nishi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.