Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clear which version of kubetest or kubetest2 is being used #20886

Closed
spiffxp opened this issue Feb 17, 2021 · 15 comments
Closed

Make it clear which version of kubetest or kubetest2 is being used #20886

spiffxp opened this issue Feb 17, 2021 · 15 comments
Assignees
Labels
area/kubetest help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone

Comments

@spiffxp
Copy link
Member

spiffxp commented Feb 17, 2021

We may have deprecated kubetest, but it's still in use. Whatever we do here should support kubetest2 or be included in kubetest2

kubernetes/kubernetes#96987 (comment) is an example of confusion over the fact that changes to kubetest don't take effect until job configs are updated to a new image (e.g. kubekins)

We could stand to document how changes flow a better. But it might help for troubleshooting if we make it clearer what version of kubetest is being used.

Ideas include:

@spiffxp
Copy link
Member Author

spiffxp commented Feb 17, 2021

/help
/kind cleanup
/sig testing
/area kubetest
/priority important-soon
/milestone v1.21

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 17, 2021
@k8s-ci-robot k8s-ci-robot added area/kubetest priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 17, 2021
@BenTheElder
Copy link
Member

cc @amwat

@supriya-premkumar
Copy link
Contributor

/assign

@spiffxp
Copy link
Member Author

spiffxp commented Mar 5, 2021

/remove-help
Please ping with any questions if you need help

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 5, 2021
supriya-premkumar added a commit to supriya-premkumar/test-infra that referenced this issue Mar 10, 2021
Changes:
	1. Adds version flag for kubetest
	2. Adds kubetest version in metadata.json
	3. Fixes kubernetes#20886
supriya-premkumar added a commit to supriya-premkumar/test-infra that referenced this issue Mar 10, 2021
Changes:
	1. Adds version flag for kubetest
	2. Adds kubetest version in metadata.json
	3. Fixes kubernetes#20886
supriya-premkumar added a commit to supriya-premkumar/test-infra that referenced this issue Mar 10, 2021
- Adds version flag for kubetest
- Adds kubetest version in metadata.json
- Fixes kubernetes#20886
@amwat
Copy link
Contributor

amwat commented Mar 11, 2021

Whatever we do here should support kubetest2 or be included in kubetest2

tracked here: kubernetes-sigs/kubetest2#108

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 9, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jun 15, 2021

/help
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 15, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
/remove-lifecycle stale

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jun 15, 2021
@supriya-premkumar
Copy link
Contributor

Hi @spiffxp, apologies for the delay. I have this WIP PR
I will revive the PR and work on this one. Thank you 🙏🏽

@BenTheElder BenTheElder modified the milestones: v1.21, v1.22 Jun 25, 2021
@spiffxp spiffxp changed the title Make it clear which version of kubetest is being used Make it clear which version of kubetest or kubetest2 is being used Jul 13, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 27, 2021

/milestone v1.23
What remains to be done here? I swear I talked about this last meeting and have already forgotten the things we linked through to discover that there was still work to actually add it to metadata.json and setup testgrid column headers

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.22, v1.23 Jul 27, 2021
@amwat
Copy link
Contributor

amwat commented Aug 7, 2021

We still need to add a testgrid column-header in https://github.com/kubernetes/test-infra/blob/master/config/testgrids/default.yaml#L10

to read https://github.com/kubernetes/test-infra/pull/21276/files#diff-71dd7bf85cfecc6c2c2fa0956ad5f182433bcc0f287aaa83f2052eb3f8ba9710R525

(probably we should consider an agnostic name to also cover kubetest2)

I also have a PR open to square off the kubetest2 parts kubernetes-sigs/kubetest2#162

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 5, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 5, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubetest help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

7 participants