Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra-Commit testgrid column missing for pod-utils jobs #20650

Open
spiffxp opened this issue Jan 28, 2021 · 8 comments
Open

Infra-Commit testgrid column missing for pod-utils jobs #20650

spiffxp opened this issue Jan 28, 2021 · 8 comments
Labels
area/kubetest area/prow/pod-utilities Issues or PRs related to prow's pod-utilities component area/testgrid kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@spiffxp
Copy link
Member

spiffxp commented Jan 28, 2021

What happened:
Compare https://testgrid.k8s.io/sig-release-master-blocking#conformance-ga-only (pod-utils) to https://testgrid.k8s.io/sig-release-master-blocking#Conformance%20-%20GCE%20-%20master (bootstrap)

The lowest column (Infra-Commit) for the pod-utils job has the value missing for all runs, whereas the bootstrap job has the sha of test-infra code being exercised.

What you expected to happen:
If the pod-utils job is missing the test-infra sha because it's not relevant (e.g. no test-infra code is exercised as part of the job, it wouldn't be helpful for troubleshooting), then the Infra-Commit column probably shouldn't exist for this job.

If the pod-utils job is exercising test-infra code, then it should be populating the data that eventually ends up in the Infra-Commit column

How to reproduce it (as minimally and precisely as possible): see above

Please provide links to example occurrences, if any: see above

Anything else we need to know?:
The Infra-Commit should-always-exist assumption needs to be removed. It's not clear to me where that exists, but this could involve fixes in

  • testgrid updater (not in this repo)
  • testgrid configurator

And if there's a need to update data produced by pod-utils, could involve fixes in

  • kubetest
  • kubetest2 (not in this repo)
  • prow's pod-utils

/area kubetest
/area testgrid
/area prow/pod-utilities
/priority important-longterm

@spiffxp spiffxp added the kind/bug Categorizes issue or PR as related to a bug. label Jan 28, 2021
@k8s-ci-robot k8s-ci-robot added area/kubetest area/testgrid area/prow/pod-utilities Issues or PRs related to prow's pod-utilities component priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jan 28, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jan 28, 2021

FYI @kubernetes/ci-signal @MushuEE

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 28, 2021
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp
Copy link
Member Author

spiffxp commented Jul 13, 2021

/reopen
/lifecycle frozen

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Reopened this issue.

In response to this:

/reopen
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Jul 13, 2021
@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jul 13, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Aug 9, 2021

/sig testing

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubetest area/prow/pod-utilities Issues or PRs related to prow's pod-utilities component area/testgrid kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

3 participants