Update SIG Release teams

[justaugustus]

• Add Licensing subproject
• Add Release Engineering subproject
• Add Release Team subproject
• Add release-team-leads team
• Rename kubernetes-milestone-maintainers to milestone-maintainers
• Rename kubernetes-release-managers to release-managers

Signed-off-by: Stephen Augustus saugustus@vmware.com

/assign @calebamiles @tpepper

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/kubernetes/sig-release/OWNERS [justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nikhita]

Nested teams have this behaviour. Just want to double check if you are ok with this, because I think it can get weird with permissions.

Child teams inherit the parent's access permissions, simplifying permissions management for large groups. Members of child teams also receive notifications when the parent team is @mentioned, simplifying communication with multiple groups of people.

Ref: https://help.github.com/en/articles/about-teams#nested-teams

[justaugustus]

Yep, yep, I reviewed the same page. That's exactly what I want i.e., a top-level pingable group for releng, that we can assign permissions to, if need be, and have them cascade into the existing groups. :)

[justaugustus]

(fixing the test failures...)
For reference:

config_test.go:248: The following members of team release-team are not Kubernetes org members: alokpatra, christianh814, chrisz, onlydole, rarchk, rawkode, sgrunert, simplytunde, timmycarr, ttousai, vivektaparia
config_test.go:248: The team release-team in org Kubernetes has org admins listed as members; these users should be in the maintainers list instead, and cannot be on the members list: spiffxp
config_test.go:248: The team release-team in org Kubernetes has an unsorted list of members
config_test.go:248: The team release-engineering in org Kubernetes has org admins listed as members; these users should be in the maintainers list instead, and cannot be on the members list: calebamiles
config_test.go:248: The team licensing in org Kubernetes has org admins listed as members; these users should be in the maintainers list instead, and cannot be on the members list: nikhita

[justaugustus]

@nikhita -- check this out:

config_test.go:248: The team licensing in org Kubernetes has users in both maintainer admin and member roles: nikhita
config_test.go:248: The team licensing in org Kubernetes has org admins listed as members; these users should be in the maintainers list instead, and cannot be on the members list: nikhita
config_test.go:248: The following members of team release-team are not Kubernetes org members: simplytunde
config_test.go:248: The team release-team in org Kubernetes has an unsorted list of members
FAIL

simplytunde didn't raise an error in the first test failure, despite the fact that he wasn't an org member.
Is there a limit on the amount of users that will be listed on a test failure?

[nikhita]

Is there a limit on the amount of users that will be listed on a test failure?

Nope, we just unmarshal the yaml and compare stuff. We don't use the API at all.

config_test.go:248: The following members of team release-team are not Kubernetes org members: alokpatra, christianh814, chrisz, onlydole, rarchk, rawkode, sgrunert, simplytunde, timmycarr, ttousai, vivektaparia

From your earlier comment, simplytunde is mentioned here. :)

[justaugustus]

Oh geez, I must be tired 😅

[nikhita]

Np :))

[cblecker]

Is there a reason we're nesting this team? Because kubernetes-release-managers is a highly privileged team, I'd prefer we don't nest anything under it, because then it's not immediately clear who has permissions.

[justaugustus]

@cblecker -- patch release was already nested under release managers, so I didn't want to upset the existing config (

org/config/kubernetes/sig-release/teams.yaml

Lines 111 to 121 in 69deb81

	patch-release-team:
	description: People managing patch releases of prior k8s minor release branches.
	maintainers:
	- justaugustus
	members:
	- aleksandra-malinowska
	- feiskyer
	- foxish
	- hoegaarden
	- tpepper
	privacy: closed

), though I agree that we should probably look at if that needs to be nested in future.

[justaugustus]

I spoke to @cblecker earlier during which he unnested the patch-release-team from kubernetes-release-managers.

After that, I made some additional updates to this, namely:

• Add release-team-leads team
• Rename kubernetes-milestone-maintainers to milestone-maintainers
• Rename kubernetes-release-managers to release-managers

This is ready for review again.

[tpepper]

/lgtm