Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release managers group in documentation #4555

Merged
merged 3 commits into from
Mar 7, 2020

Conversation

jtslear
Copy link
Contributor

@jtslear jtslear commented Feb 28, 2020

The existing group was not valid. This may have been updated at some point. This ensures the documentation is pointed to the correct group.

The existing group was not valid.  This may have been updated at some point.  This ensures the documentation is pointed to the correct group.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 28, 2020
Copy link
Contributor

@markjacksonfishing markjacksonfishing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Feb 28, 2020
@markjacksonfishing
Copy link
Contributor

@jtslear can you run a 'make generate'

@justaugustus
Copy link
Member

All of the go is rubbing off on me! I dropped the kubernetes- in kubernetes/org#828 to remove the stutter when mentioning the team.

Thanks for updating the reference! I'll approve this once the yaml is regenerated, as @markyjackson-taulia mentioned.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 5, 2020
@justaugustus
Copy link
Member

@jtslear -- Can you check in on this? The PR doesn't have any content right now.
Also, the commits need to be squashed once you recover the content.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2020
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2020
@jtslear
Copy link
Contributor Author

jtslear commented Mar 6, 2020

@justaugustus it would appear that the make generate wiped out my desired changes. Now that I've learned how to contribute to this particular repo, we should be good to go with the latest changes. My apologies 😬

@justaugustus
Copy link
Member

Hehe, no worries, John. Thanks again for the fix!
/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2020
@cblecker
Copy link
Member

cblecker commented Mar 7, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, jtslear, justaugustus, markyjackson-taulia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit d22a34d into kubernetes:master Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants