Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client go teams #618

Merged
merged 2 commits into from
Mar 17, 2019
Merged

Conversation

rlenferink
Copy link
Member

Created the missing teams for the kubernetes-client repos (#615).
Added a description to the python-base-admins team as well.

@nikhita can you assign the repository permissions to the teams?
@brendandburns is this sufficient for you to setup the CI/CD pipelines?

/assign @nikhita

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 17, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 17, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2019
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omg thank you, Roy!! 💖

I'll make sure that these teams have admin permissions. 👍

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, rlenferink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9596aa7 into kubernetes:master Mar 17, 2019
@nikhita
Copy link
Member

nikhita commented Mar 17, 2019

All teams mentioned here have been granted admin priviliges to their respective repos.

@rlenferink rlenferink deleted the add-client-go-teams branch March 18, 2019 05:30
@rlenferink
Copy link
Member Author

Thanks so much for your help Nikhita !! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants