Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brendandburns to kubernetes-client owners #615

Closed
wants to merge 1 commit into from

Conversation

brendandburns
Copy link

This is needed for me to use Azure pipelines for CI/CD for CSharp and other projects.

(I'm also the primary maintainer for most of the client libraries)

Thanks!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: brendandburns
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: idvoretskyi

If they are not already assigned, you can assign the PR to them by writing /assign @idvoretskyi in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 16, 2019
@k8s-ci-robot
Copy link
Contributor

@brendandburns: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-org-test-all 49a7169 link /test pull-org-test-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justaugustus
Copy link
Member

Hey @brendandburns, org admins are also (by default) maintainers of the GitHub teams that they belong to, which is why the test is failing here:

FAIL: //config:go_default_test (see /root/.cache/bazel/_bazel_root/e50ebc2a7cac8d93968e5988863c67ce/execroot/__main__/bazel-out/k8-fastbuild/testlogs/config/go_default_test/test.log)
INFO: From Testing //config:go_default_test:
==================== Test output for //config:go_default_test:
--- FAIL: TestAllOrgs (0.09s)
config_test.go:248: The team haskell-admins in org Kubernetes Clients has org admins listed as members; these users should be in the maintainers list instead, and cannot be on the members list: brendandburns
config_test.go:248: The team ruby-admins in org Kubernetes Clients has org admins listed as members; these users should be in the maintainers list instead, and cannot be on the members list: brendandburns
config_test.go:248: The team gen-admins in org Kubernetes Clients has org admins listed as members; these users should be in the maintainers list instead, and cannot be on the members list: brendandburns
config_test.go:248: The team javascript-admins in org Kubernetes Clients has org admins listed as members; these users should be in the maintainers list instead, and cannot be on the members list: brendandburns
config_test.go:248: The team csharp-admins in org Kubernetes Clients has org admins listed as members; these users should be in the maintainers list instead, and cannot be on the members list: brendandburns
config_test.go:248: The team java-admins in org Kubernetes Clients has org admins listed as members; these users should be in the maintainers list instead, and cannot be on the members list: brendandburns
FAIL

To fix it, you can add a maintainers section with your username to each team you need to be a part of, and remove yourself from the members field e.g.,

  csharp-admins:
    description: admin access to csharp
    maintainers:
    - brendandburns
    members:
    - krabhishek8260
    privacy: closed

@@ -5,6 +5,7 @@ has_organization_projects: true
has_repository_projects: true
members_can_create_repositories: false
admins:
- brendandburns
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the GitHub admin team can be in the admins list: https://github.com/kubernetes/community/tree/master/github-management#github-administration-team

To get admin permissions across repos in the kubernetes-client org, can you create teams for each repo like below? 😬

  csharp-admins:
    description: admin access to csharp
    members:
    - brendandburns
    - krabhishek8260
    privacy: closed

I'll then grant admin privileges to these teams.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty to go ahead with this and create the go-admins and go-base-admins teams (#618) which were the only repositories not belonging to a team (yet).

@rlenferink rlenferink mentioned this pull request Mar 17, 2019
@nikhita
Copy link
Member

nikhita commented Mar 17, 2019

Closing in favor of #618.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants