Add teams for kubernetes-sigs/kubebuilder-declarative-pattern #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
spiffxp
changed the title
spiffxp
force-pushed
the
add-kubebuilder-declarative-pattern-teams
branch
from
6734c3b
to
e265e6a
Compare
|
/lgtm |
k8s-ci-robot
added
lgtm
justaugustus
suggested changes
Feb 19, 2019
There was a problem hiding this comment.
@spiffxp -- team members need to be sorted and there's a member that isn't part of k orgs:
--- FAIL: TestAllOrgs (0.08s)
config_test.go:248: The following members of team kubebuilder-declarative-pattern-admins are not Kubernetes SIGs org members: johnsonj
config_test.go:248: The team kubebuilder-declarative-pattern-admins in org Kubernetes SIGs has an unsorted list of members
config_test.go:248: The following members of team kubebuilder-declarative-pattern-maintainers are not Kubernetes SIGs org members: johnsonj
config_test.go:248: The team kubebuilder-declarative-pattern-maintainers in org Kubernetes SIGs has an unsorted list of members
I started the pattern of sig-api-machinery having its own dir for teams, and moved teams out of kubernetes-sigs/org.yaml that were related to the server-sdk subproject while I was here. I also updated their descriptions. johnsonj is not yet an org member, so I have commented them out with a ref to the comment asking that they join
spiffxp
force-pushed
the
add-kubebuilder-declarative-pattern-teams
branch
from
d116090
to
49e8e26
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started the pattern of sig-api-machinery having its own dir
for teams, and moved teams out of kubernetes-sigs/org.yaml that
were related to the server-sdk subproject while I was here. I
also updated their descriptions.
ref: #418