Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New repo: kubernetes-sigs/kubebuilder-declarative-pattern #418

Closed
johnsonj opened this issue Jan 24, 2019 · 12 comments
Closed

New repo: kubernetes-sigs/kubebuilder-declarative-pattern #418

johnsonj opened this issue Jan 24, 2019 · 12 comments
Assignees
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository

Comments

@johnsonj
Copy link

New Repo, Staging Repo, or migrate existing

new repository

Requested name for new repository

kubebuilder-declarative-pattern

Which Organization should it reside

kubernetes-sigs

If not a staging repo, who should have admin access

@kubernetes-sigs/kubebuilder-admins, @justinsb, @johnsonj

If not a staging repo, who should have write access

@kubernetes-sigs/kubebuilder-admins, @justinsb, @johnsonj

If a new repo, who should be listed as approvers in OWNERS

@kubernetes-sigs/kubebuilder-admins, @justinsb, @johnsonj

If a new repo, who should be listed in SECURITY_CONTACTS

@kubernetes-sigs/kubebuilder-admins, @justinsb, @johnsonj

What should the repo description be

A toolkit for building declarative operators with kubebuilder.

What SIG and subproject does this fall under in sigs.yaml

This is part of the kubebuilder subproject for SIG API Machinery.

Approvals

Additional context for request

@johnsonj johnsonj added the area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository label Jan 24, 2019
@DirectXMan12
Copy link

DirectXMan12 commented Jan 24, 2019

Reiterating my approval: 👍 for easy reference

@justinsb
Copy link
Member

justinsb commented Feb 6, 2019

@cblecker is this something you can help with please?

@nikhita
Copy link
Member

nikhita commented Feb 15, 2019

Would be awesome if we could have kubernetes/community#3018 (comment) get merged in as well and get ack's from the people listed there.

cc @deads2k @lavalamp @sttts @pwittrock @cheftako

@pwittrock
Copy link
Member

/lgtm

@spiffxp
Copy link
Member

spiffxp commented Feb 18, 2019

Until the followup mentioned in kubernetes/community#3018 (comment) is opened and merged, I would like an approval from SIG API machinery leadership, or a confirmation that the earlier approval of "kubebuilder-addon-pattern" applies for "kubebuilder-declaritive-pattern"

@nikhita
Copy link
Member

nikhita commented Feb 18, 2019

/assign @deads2k @lavalamp

@lavalamp
Copy link
Member

/lgtm

@spiffxp
Copy link
Member

spiffxp commented Feb 19, 2019

/unassign @lavalamp @deads2k
/assign
I'll take that for approval and work on this

@spiffxp
Copy link
Member

spiffxp commented Feb 19, 2019

  • Opened Add teams for kubernetes-sigs/kubebuilder-declarative-pattern #505 to create teams for repo admin/write access
  • Opened Add kubernetes-declarative-pattern to server-sdk subproject community#3278 to add to sigs.yaml (this was an educated guess based on where kubebuilder fell within existing subprojects)
  • Created https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern with default settings
  • Set description per the repo creation request
  • Cloned newly created / bare repo locally
  • Copied over latest contents of kubernetes/kubernetes-template-project and committed as initial commit with message "Initial commit from kubernetes-template-project"
  • Next commit:
    • Updated OWNERS_ALIASES to remove steering-committee alias per the TODO (ordinarily I would remove the file entirely, but in this case the request is referencing a GitHub team, so...)
    • Added a kubebuilder-admins alias, populated based on the @kubernetes-sigs/kubebuilder-admins
      GitHub team
    • Updated OWNERS per this repo creation request (add a labels entry for the sig this repo/subproject belongs to)
    • Updated SECURITY_CONTACTS per this repo creation request (can't use aliases, so expanded the team)
  • Pushed directly to master
  • Manually update repo topic to "k8s-sig-api-machinery"

At this point the repo is ready for PR's.

TODO:

@spiffxp
Copy link
Member

spiffxp commented Feb 19, 2019

@johnsonj it turns out you are not a member of kubernetes or kubernetes-sigs, so I can't add you to the things, can you please file a membership request?

@nikhita
Copy link
Member

nikhita commented Feb 22, 2019

Once #505 is merged and the postsubmit has finished, the teams should appear, update collaborators manually

The postsubmit has run and the new teams have been created. I have updated access as follows:

  • kubebuilder-admins and kubebuilder-declarative-pattern-admins have admin access
  • kubebuilder-declarative-pattern-maintainers has write access

The PR to update sigs.yaml (kubernetes/community#3278) has also merged, so closing this issue.

/close

@k8s-ci-robot
Copy link
Contributor

@nikhita: Closing this issue.

In response to this:

Once #505 is merged and the postsubmit has finished, the teams should appear, update collaborators manually

The postsubmit has run and the new teams have been created. I have updated access as follows:

  • kubebuilder-admins and kubebuilder-declarative-pattern-admins have admin access
  • kubebuilder-declarative-pattern-maintainers has write access

The PR to update sigs.yaml (kubernetes/community#3278) has also merged, so closing this issue.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository
Projects
None yet
Development

No branches or pull requests

9 participants