Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mowangdk to alibaba-cloud-csi-driver admin and remove fredkan from alibaba-cloud-csi-driver #4145

Merged
merged 2 commits into from
May 3, 2023

Conversation

JiaoDean
Copy link
Contributor

@JiaoDean JiaoDean commented Apr 6, 2023

add mowangdk to alibaba-cloud-csi-driver admin

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 6, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: JiaoDean / name: Mr.Jiao (4b7a8d7)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 6, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @JiaoDean!

It looks like this is your first PR to kubernetes/org 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/org has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @JiaoDean. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 6, 2023
@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 6, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 7, 2023
@JiaoDean JiaoDean changed the title add mowangdk to alibaba-cloud-csi-driver admin add mowangdk to alibaba-cloud-csi-driver admin and remove fredkan from alibaba-cloud-csi-driver Apr 7, 2023
@fredkan
Copy link
Member

fredkan commented Apr 7, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2023
@mowangdk
Copy link

mowangdk commented Apr 7, 2023

@nikhita Please take a loot at this when you have time. related to #3833

@nikhita
Copy link
Member

nikhita commented Apr 7, 2023

@nikhita Please take a loot at this when you have time. related to #3833

Would like a cloud-provider lead to approve.

/assign @nckturner
@nckturner : I've updated OWNERS files in #4148. Once that gets merged, you should be able to approve these changes.

@mowangdk
Copy link

mowangdk commented Apr 8, 2023

@nikhita Please take a loot at this when you have time. related to #3833

Would like a cloud-provider lead to approve.

/assign @nckturner @nckturner : I've updated OWNERS files in #4148. Once that gets merged, you should be able to approve these changes.

sure, @cuericlee This pr requires your approval~

@cuericlee
Copy link

/lgtm

@nikhita Please take a loot at this when you have time. related to #3833

Would like a cloud-provider lead to approve.
/assign @nckturner @nckturner : I've updated OWNERS files in #4148. Once that gets merged, you should be able to approve these changes.

sure, @cuericlee This pr requires your approval~

@k8s-ci-robot
Copy link
Contributor

@cuericlee: changing LGTM is restricted to collaborators

In response to this:

/lgtm

@nikhita Please take a loot at this when you have time. related to #3833

Would like a cloud-provider lead to approve.
/assign @nckturner @nckturner : I've updated OWNERS files in #4148. Once that gets merged, you should be able to approve these changes.

sure, @cuericlee This pr requires your approval~

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mowangdk
Copy link

@nckturner PTAL, thx

@mowangdk
Copy link

@nikhita @nckturner hasn't recovered, please help to merge, cloud-provider leader has approved. thank a lot 🙇

@mowangdk
Copy link

@nikhita @nckturner hasn't recovered, please help to merge, cloud-provider leader has approved. thank a lot 🙇

@nikhita Does this pr still need approval from anyone? ptal

@mrbobbytables
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 27, 2023
@mrbobbytables
Copy link
Member

assigning more cloud provider leads for review
/assign @andrewsykim @nckturner @cheftako @bridgetkromhout @elmiko

@elmiko
Copy link

elmiko commented May 3, 2023

/lgtm

Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JiaoDean, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2c5585d into kubernetes:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.