Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add owners as alibaba-csi-plugin admin #3833

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Add owners as alibaba-csi-plugin admin #3833

merged 1 commit into from
Mar 21, 2023

Conversation

fredkan
Copy link
Member

@fredkan fredkan commented Nov 11, 2022

cuericlee, denverdino, JiaoDean and mowangdk are working on alibabacloud csi plugin as admin. I'm proposing to add them as proper admin of alibaba-cloud-csi-driver project.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 11, 2022
@k8s-ci-robot k8s-ci-robot added the area/github-management Issues or PRs related to GitHub Management subproject label Nov 11, 2022
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 11, 2022
@fredkan
Copy link
Member Author

fredkan commented Nov 11, 2022

/retest

@fredkan fredkan force-pushed the add_owners_to_alibabacloud_csi_plugin branch from 5e4437f to b4e0b27 Compare November 11, 2022 13:07
@fredkan
Copy link
Member Author

fredkan commented Nov 16, 2022

@andrewsykim please help to review this pr, thanks.

@fredkan
Copy link
Member Author

fredkan commented Nov 29, 2022

@andrewsykim @cheftako please review this pr. thank you.

@fredkan
Copy link
Member Author

fredkan commented Jan 5, 2023

@andrewsykim @cheftako please help to review this pr. thank you.

@cuericlee
Copy link

@andrewsykim @cheftako please review this PR and transfer admin to new owner， we will take account of the maintenance of alibaba-csi-plugin project on behalf of AlibabaCloud in the future as @fredkan move on new opportunity! Thanks.

cuericlee
cuericlee suggested changes Feb 24, 2023
View reviewed changes
Copy link

@cuericlee cuericlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add following 4 maintainers
cuericlee
denverdino
JiaoDean
mowangdk

@cuericlee
Copy link

@nikhita would you please help approve this team change request?

@nikhita
Copy link
Member

nikhita commented Mar 9, 2023

@fredkan move on new opportunity

I see @fredkan still listed in the team. Is that expected?

@fredkan
Copy link
Member Author

fredkan commented Mar 10, 2023

@fredkan move on new opportunity

I see @fredkan still listed in the team. Is that expected?

Yes, I will be removed in next PR, thanks.

@fredkan
Copy link
Member Author

fredkan commented Mar 21, 2023

@fredkan move on new opportunity

I see @fredkan still listed in the team. Is that expected?

@nikhita Hi, I move on other opportunity, and not focus on this project. Please help to merge this PR;
@JiaoDean will submit another PR to remove me from the list.

nikhita
nikhita approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fredkan, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 597c707 into kubernetes:main Mar 21, 2023
@mowangdk mowangdk mentioned this pull request Apr 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuericlee cuericlee cuericlee requested changes

@nikhita nikhita nikhita approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fredkan @cuericlee @nikhita @k8s-ci-robot