Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new staging repo: k8s.io/dynamic-resource-allocation #3821

Closed
pohly opened this issue Nov 6, 2022 · 14 comments
Closed

new staging repo: k8s.io/dynamic-resource-allocation #3821

pohly opened this issue Nov 6, 2022 · 14 comments
Assignees

Comments

@pohly
Copy link
Contributor

pohly commented Nov 6, 2022

From https://groups.google.com/g/kubernetes-sig-architecture/c/DkKQyuUrj9Y:

The dynamic resource allocation implementation is under review for
inclusion into Kubernetes 1.26 as new alpha feature. The full set of
commits is pending in
kubernetes/kubernetes#111023.

It contains code that is used in-tree and out-of-tree. Initially we
thought that we would publish such helper code later, but NVIDIA already
started using it in their prototype of a dynamic resource allocation
driver, therefore it makes sense to publish it properly already with
Kubernetes 1.26.

Therefore I would like to request a new staging repo
"k8s.io/dynamic-resource-allocation" where we will publish these helper
packages. In some earlier revision I had the code under
"k8s.io/component-helpers", but it changed the dependencies of that
module. IMHO a separate staging repo is cleaner. It should be owned by
SIG Node, with the set of people working on dynamic resource allocation
as reviewers. SIG Node leads would be approvers plus Kevin and myself.

There have been no comments there, so I suppose there are no objections and we can proceed.

/cc @thockin (in case that explicit approval is needed)

@klueska
Copy link
Contributor

klueska commented Nov 7, 2022

/assign @derekwaynecarr

This needs sig-node-leads approval as per this slack conversation:
https://kubernetes.slack.com/archives/C01672LSZL0/p1667751787905519

@klueska
Copy link
Contributor

klueska commented Nov 7, 2022

/approve (as sig-node-approver)

@dchen1107
Copy link
Member

/lgtm
/approve

@alculquicondor
Copy link
Member

I think this needs resolution on kubernetes/kubernetes#111023 (comment)

pohly added a commit to pohly/publishing-bot that referenced this issue Nov 11, 2022
This is needed for helper code for the dynamic resource allocation feature. The
code will be added in kubernetes/kubernetes#111023

The repo request is in kubernetes/org#3821
@johnbelamaric
Copy link
Member

/approve

@mrbobbytables
Copy link
Member

repo created: https://github.com/kubernetes/dynamic-resource-allocation
PR for branch protection: kubernetes/test-infra#27980
Final step will be completed once PR in k/k is merged.

/assign

@pohly
Copy link
Contributor Author

pohly commented Nov 13, 2022

The PR has been merged.

Publishing bot also was updated: kubernetes/publishing-bot#300

@mrbobbytables
Copy link
Member

I think everything is done as far as getting the repo squared away.

The only administrative action left is to add it to k/community listed under a subproject

Would it be a new one or should it be listed under one of the others?

@klueska
Copy link
Contributor

klueska commented Nov 15, 2022

Let me ask what people prefer in the sig-node meeting today.

@klueska
Copy link
Contributor

klueska commented Nov 17, 2022

We discussed this in the sig-node meeting on Tuesday.

The consensus was for me to create a new subproject called resource-management which will absorb the existing noderesourcetopology-api subproject and include both this new staging repo and the repo that will result from my recent request for a kubernetes-sigs/dra-example-driver repo.

The first step is to open a PR against https://github.com/kubernetes/community to update the README with the new organization. What are the following steps? It looks like maybe an update to https://github.com/kubernetes/community/blob/master/sigs.yaml as well? Anything else?

@klueska
Copy link
Contributor

klueska commented Nov 18, 2022

PR to add the above:
kubernetes/community#6970

@klueska
Copy link
Contributor

klueska commented Nov 22, 2022

With the merging of kubernetes/community#6970, I assume this issue can now be closed?

@mrbobbytables
Copy link
Member

yup!

/close

@k8s-ci-robot
Copy link
Contributor

@mrbobbytables: Closing this issue.

In response to this:

yup!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

8 participants