Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource-management subproject to sig-node #6970

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

klueska
Copy link
Contributor

@klueska klueska commented Nov 18, 2022

Add resource-management subproject to sig-node

As part of this, add dynamic-resource-management staging repo as part of this subproject as well as absorb the (previously) standalone subproject for noderesourcetopology-api into this new subproject.

/cc @derekwaynecarr
/cc @swatisehgal
/cc @pohly

As part of this, add dynamic-resource-management staging repo as part of
this subproject as well as absorb the (previously) standalone subproject
for noderesourcetopology-api into this new subproject.

Signed-off-by: Kevin Klues <kklues@nvidia.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Nov 18, 2022
@swatisehgal
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2022
@pohly
Copy link
Contributor

pohly commented Nov 18, 2022

/assign @palnabarun

For approval.

sigs.yaml Outdated
owners:
- https://raw.githubusercontent.com/kubernetes/dynamic-resource-allocation/master/OWNERS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- https://raw.githubusercontent.com/kubernetes/dynamic-resource-allocation/master/OWNERS
- https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/dynamic-resource-allocation/OWNERS

For staging repos, they should point to their location in k/k as that is the authoritative place for the code 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated thanks.

Signed-off-by: Kevin Klues <kklues@nvidia.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2022
@klueska
Copy link
Contributor Author

klueska commented Nov 21, 2022

/assign @palnabarun

Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klueska, mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit bbadbda into kubernetes:master Nov 22, 2022
@derekwaynecarr
Copy link
Member

just caught up on slack after holiday, happy to see this growth in the sig.

/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants