-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bsutil (kubeadm) unit tests (testdata) #9713
Conversation
Hi @prezha. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, prezha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes: #9707
this pr replaces the hard-coded list of k8s versions to test and builds it dynamically from the existing testdata versions subdirectories, and also handles the case when
<major>.<minor>.0
stable version is not yet released (eg, as with 'v1.20.0-beta.1') by using the latest k8s pre-release version available until stable version gets out, so to have only one set (subdirectory) with test data for each<major>.<minor>
k8s version underpkg/minikube/bootstrapper/bsutil/testdata/