Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kubeadm unit tests (testdata) #9707

Closed
prezha opened this issue Nov 15, 2020 · 2 comments · Fixed by #9713
Closed

fix kubeadm unit tests (testdata) #9707

prezha opened this issue Nov 15, 2020 · 2 comments · Fixed by #9713
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@prezha
Copy link
Contributor

prezha commented Nov 15, 2020

ref: #9694
ref: #9693

currently, bsutil (kubeadm) unit tests have hardcoded list of versions to test, referencing testdata subdirectories for relevant k8s version to test, and it has to be manually updated with each new version released, eg:

versions := []string{"v1.20.0-beta.1", "v1.19", "v1.18", "v1.17", "v1.16", "v1.15", "v1.14", "v1.13", "v1.12"}

and

versions := []string{"v1.20.0-beta.1", "v1.19", "v1.18", "v1.17", "v1.16", "v1.15", "v1.14", "v1.13", "v1.12"}

we also need to cover the situation where we still don't have the <major>.<minor>.0 stable version released (eg, as with 'v1.20.0-beta.1'), in which case we should use that latest k8s version until stable version gets released in test data files

therefore, it would be good to:

  • have a dynamic (auto-discover) list of k8s versions to test (hack update: generate unit tests for new k8rs version #9708 will automatically create new testdata set for newer versions), while also
  • have only one set (subdirectory) with test data for each <major>.<minor> k8s version under pkg/minikube/bootstrapper/bsutil/testdata/
@prezha
Copy link
Contributor Author

prezha commented Nov 15, 2020

/assign

@medyagh medyagh added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 15, 2020
@medyagh
Copy link
Member

medyagh commented Nov 15, 2020

this is a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants