Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kubernetes version #9693

Merged
merged 2 commits into from
Nov 13, 2020
Merged

update kubernetes version #9693

merged 2 commits into from
Nov 13, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Nov 13, 2020

I used the script

cd hack/update/kubernetes_version
go run update_kubernetes_version.go

except it didnt generate the test data

pkg/minikube/bootstrapper/bsutil/kubeadm_test.go
pkg/minikube/bootstrapper/bsutil/testdata/v1.20.0-beta.1

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2020
@prezha
Copy link
Contributor

prezha commented Nov 13, 2020

@medyagh yes, we'll find a way to add new test data with new k8s version
do you think that the folder should be called

pkg/minikube/bootstrapper/bsutil/testdata/v1.20

ie, v<major>.<minor>, instead of

pkg/minikube/bootstrapper/bsutil/testdata/v1.20.0-beta.1

like all the others there, so that we don't need to change it with every patch and/or -beta/-rc release?

@medyagh
Copy link
Member Author

medyagh commented Nov 13, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 13, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9693): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9693/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9693/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9693): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9693/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9693/minikube: exec format error

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 992c113 into kubernetes:master Nov 13, 2020
@medyagh medyagh deleted the k8s_ver_v15 branch March 2, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants