-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hack/update package to automate PR generation #9464
Add hack/update package to automate PR generation #9464
Conversation
Hi @prezha. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #9464 +/- ##
==========================================
- Coverage 29.20% 29.05% -0.16%
==========================================
Files 171 171
Lines 10447 10443 -4
==========================================
- Hits 3051 3034 -17
- Misses 6972 6987 +15
+ Partials 424 422 -2
|
Travis tests have failedHey @prezha, 1st Buildmake test
TravisBuddy Request Identifier: 8768a940-100b-11eb-8acb-27a1e4e1eb88 |
Hey @prezha - this PR is doing a lot. Do you mind splitting up the PR's to automate the various steps? It's fine if you want to just send one at a time. |
hey @tstromberg, yes, of course: i've made some additional minor changes (mostly for consistency) and then split this pr into four parts/prs, each having their own references to other relevant issues/prs - in summary:
if this is ok, it's ready for review, and if for a more 'synchronous' conversation, i'm also available on k8s slack - happy to jump in |
Thank you! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prezha, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes: #4392
fixes: #9264
fixes: #9420
etc.
continued work on scripting and automating various update processes:
proposal to reuse the same approach as in pr #9384 also for issues eg, #9264 [update go version to be 1.15 in go mod], #9420 [automate pushing kicbase image from snapshot to stable after release], and potentially others that have similar requirements (ie, fully/semi-automated patching of specific files + additional actions)
the idea is that we just need to define what we want to update and with which values - as simple as possible, and leave implementation details to available functions
i have restructured the code accordingly and also expanded to include functionalities for above-mentioned issues
so, currently, with this, we can: track new kubernetes stable & latest versions, new goland stable versions, update any local fs files, update any files on github, automatically create pr for those changes (if one does not exists already), update all three remote container registries we use here (ie, gcr, docker, and github), and, if that makes sense, we can further expand
examples of automatically created (test) PRs:
example command outputs: