hack/update: kicbase version

[prezha]

fixes: #9464
fixes: #9420
replaces: #9439

pr #9464 ("automate update processes") split: part 4/4 includes: hack/update/kicbase_version/update_kicbase_version.go

[k8s-ci-robot]

Hi @prezha. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[TravisBuddy]

Travis tests have failed

Hey @prezha,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.15.2.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.15.2.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.14.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.14.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="7c33a8ae7f1d97bce8ee7c8f8776dd721ae96440" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v3" ./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.30.0'
golangci/golangci-lint info found version: 1.30.0 for v1.30.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
WARN [runner] Can't run linter goanalysis_metalinter: S1010: failed prerequisites: [(inspect@k8s.io/minikube/hack/update/kicbase_version, isgenerated@k8s.io/minikube/hack/update/kicbase_version): analysis skipped: errors in package: [/home/travis/gopath/src/github.com/kubernetes/minikube/hack/update/kicbase_version/update_kicbase_version.go:59:2: could not import k8s.io/minikube/hack/update (hack/update/kicbase_version/update_kicbase_version.go:59:2: cannot find module providing package k8s.io/minikube/hack/update: module k8s.io/minikube/hack/update: reading https://proxy.golang.org/k8s.io/minikube/hack/update/@v/list: 410 Gone
	server response: not found: module k8s.io/minikube/hack/update: no matching versions for query "latest")]] 
WARN [runner] Can't run linter unused: buildir: failed to load package : could not load export data: no export data for "k8s.io/minikube/hack/update" 
ERRO Running error: buildir: failed to load package : could not load export data: no export data for "k8s.io/minikube/hack/update" 
Makefile:434: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 3
= go mod ================================================================
go: finding module for package k8s.io/minikube/hack/update
k8s.io/minikube/hack/update/kicbase_version imports
	k8s.io/minikube/hack/update: cannot find module providing package k8s.io/minikube/hack/update: module k8s.io/minikube/hack/update: reading https://proxy.golang.org/k8s.io/minikube/hack/update/@v/list: 410 Gone
	server response: not found: module k8s.io/minikube/hack/update: no matching versions for query "latest"
= boilerplate ===========================================================
ok
Makefile:315: recipe for target 'test' failed
make: *** [test] Error 6
travis_time:end:145102c5:start=1603414444611528578,finish=1603414657110062435,duration=212498533857,event=script

TravisBuddy Request Identifier: 9cff9240-14d0-11eb-aff7-dd8cbeb067cc

[sharifelgamal]

I think in breaking up your update PRs, some sort of dependency broke, is there a PR blocking this one?

[prezha]

@sharifelgamal the conflicts were due to the pr #9464 (the original one - before i've split it into several prs) got merged first, and i had a couple of changes made in those individual prs; essentially my fault, i should have had closed the original pr right after the split (but left it just in case anyone wanted to compare)...

i've fixed this one now, should be ok to merge

[codecov-io]

Codecov Report

Merging #9532 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9532      +/-   ##
==========================================
- Coverage   29.04%   29.04%   -0.01%     
==========================================
  Files         172      172              
  Lines       10488    10499      +11     
==========================================
+ Hits         3046     3049       +3     
- Misses       7017     7025       +8     
  Partials      425      425              

Impacted Files	Coverage Δ
cmd/minikube/cmd/root.go	43.57% <0.00%> (-3.72%)	⬇️
pkg/addons/validations.go	33.33% <0.00%> (+16.66%)	⬆️

[tstromberg]

Thank you!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prezha, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment