Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automate pushing kicbase image from snapshot to stable after release #9439

Merged
merged 2 commits into from
Oct 28, 2020

Conversation

prezha
Copy link
Contributor

@prezha prezha commented Oct 11, 2020

fixes: #9420

as described in issue #9420, the new script automates pushing kicbase image from snapshot to stable after release

make test pass

successfully tested with:

  • gcr json token
  • docker personal access token and password
  • github personal access token

example

starting point

❯ docker images
REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE

run

❯ go run release_kicbase_version.go
I1011 23:04:21.755065   16083 release_kicbase_version.go:144] current kic base image version: v0.0.13-snapshot1
I1011 23:04:21.755106   16083 release_kicbase_version.go:148] release kic base image version: v0.0.13
I1011 23:04:39.613507   16083 release_kicbase_version.go:155] local kic base reference image: docker.io/prezha/kicbase
I1011 23:04:40.093006   16083 release_kicbase_version.go:171] successfully logged in to Google Cloud Container Registry
I1011 23:04:40.132812   16083 release_kicbase_version.go:178] successfully tagged gcr.io/minikube-292219/kicbase:v0.0.13 for Google Cloud Container Registry
I1011 23:04:57.696525   16083 release_kicbase_version.go:185] successfully pushed gcr.io/minikube-292219/kicbase:v0.0.13 to Google Cloud Container Registry
I1011 23:04:57.696535   16083 release_kicbase_version.go:188] successfully updated Google Cloud Container Registry
I1011 23:04:59.027895   16083 release_kicbase_version.go:171] successfully logged in to Docker Hub Container Registry
I1011 23:04:59.061744   16083 release_kicbase_version.go:178] successfully tagged docker.io/prezha/kicbase:v0.0.13 for Docker Hub Container Registry
I1011 23:05:09.179529   16083 release_kicbase_version.go:185] successfully pushed docker.io/prezha/kicbase:v0.0.13 to Docker Hub Container Registry
I1011 23:05:09.179569   16083 release_kicbase_version.go:188] successfully updated Docker Hub Container Registry
I1011 23:05:09.754035   16083 release_kicbase_version.go:171] successfully logged in to GitHub Packages Registry
I1011 23:05:09.791821   16083 release_kicbase_version.go:178] successfully tagged docker.pkg.github.com/triplepoint-tech/minikube/kicbase:v0.0.13 for GitHub Packages Registry
I1011 23:05:13.693656   16083 release_kicbase_version.go:185] successfully pushed docker.pkg.github.com/triplepoint-tech/minikube/kicbase:v0.0.13 to GitHub Packages Registry
I1011 23:05:13.693667   16083 release_kicbase_version.go:188] successfully updated GitHub Packages Registry

end result

❯ docker images
REPOSITORY                                                TAG                 IMAGE ID            CREATED             SIZE
prezha/kicbase                                            v0.0.13             90f1294ff9ac        12 days ago         800MB
prezha/kicbase                                            v0.0.13-snapshot1   90f1294ff9ac        12 days ago         800MB
docker.pkg.github.com/triplepoint-tech/minikube/kicbase   v0.0.13             90f1294ff9ac        12 days ago         800MB
gcr.io/minikube-292219/kicbase                            v0.0.13             90f1294ff9ac        12 days ago         800MB

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 11, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @prezha. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 11, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 11, 2020
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented Oct 11, 2020

Codecov Report

Merging #9439 into master will decrease coverage by 0.06%.
The diff coverage is 24.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9439      +/-   ##
==========================================
- Coverage   29.18%   29.11%   -0.07%     
==========================================
  Files         171      172       +1     
  Lines       10462    10461       -1     
==========================================
- Hits         3053     3046       -7     
- Misses       6985     6990       +5     
- Partials      424      425       +1     
Impacted Files Coverage Δ
cmd/minikube/cmd/config/addons.go 0.00% <0.00%> (ø)
cmd/minikube/cmd/config/addons_list.go 12.06% <0.00%> (ø)
cmd/minikube/cmd/config/config.go 7.69% <0.00%> (ø)
cmd/minikube/cmd/config/profile_list.go 2.56% <0.00%> (ø)
cmd/minikube/cmd/config/prompt.go 13.23% <0.00%> (ø)
cmd/minikube/cmd/dashboard.go 1.06% <0.00%> (ø)
cmd/minikube/cmd/docker-env.go 37.27% <0.00%> (ø)
cmd/minikube/cmd/kubectl.go 0.00% <0.00%> (ø)
cmd/minikube/cmd/mount.go 8.33% <0.00%> (ø)
cmd/minikube/cmd/node_list.go 7.69% <0.00%> (ø)
... and 87 more

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prezha, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2020
@tstromberg
Copy link
Contributor

Thank you!

@tstromberg tstromberg merged commit a78fc8b into kubernetes:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automate pushing kicbase image from snapshot to stable after release
5 participants