Enable awsecr-creds addon #901
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Can one of the admins verify this patch? |
stevesloka
force-pushed
the
awsecr-creds-addon
branch
from
f959a7c to
0c6b6f5
Compare
… downloading docker images
stevesloka
force-pushed
the
awsecr-creds-addon
branch
from
0c6b6f5 to
7e989d1
Compare
Current coverage is 33.12% (diff: 100%)@@ master #901 diff @@
==========================================
Files 43 43
Lines 1899 1899
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 629 629
Misses 1150 1150
Partials 120 120
|
|
@minikube-bot ok to test |
| @@ -0,0 +1,44 @@ | |||
|
|
|||
There was a problem hiding this comment.
Not sure if its exactly needed on these yamls since it passed our boilerplate test - but the K8s Copyright Header is missing here
There was a problem hiding this comment.
Ignore this comment - it isn't enforced upstream on k8s either
|
It can be in a different PR but I think that addons which require additional setup (the inclusion of the secrets file) should have a callback that outputs instructions to the user. |
|
@aaron-prindle I can do the additional step as a 2nd PR |
|
This LGTM, we can follow up with the help text. |
|
Awesome thanks @aaron-prindle & @r2d4 I'll get to work on the next PR for the help text next. |
|
Sorry to resurrect an old PR, but does anyone think this is kinda sketchy? There's 0 transparency about what this image/container actually does: No description, it's not an automated build from a public github repo either. |
|
@ghostsquad |
|
@aaron-prindle thanks. I'm contributing to that repo to help increase the transparency. |
This addon will automatically setup credentials to allow for minikube to pull images from an ECR docker registry running on AWS.
It requires a secret to be created to function. That secret contains the AWS_ACCESS_ID, AWS_SECRET_ACCESS_KEY as well as the AWS Account Id.
This resolves #366