Allow for addons to prompt for data input #1143

stevesloka · 2017-02-17T18:49:55Z

This allows for an addon to prompt for data. My use case is registry-creds needs additional secrets to enable pulling credentials from a registry. This should vastly simplify this need by prompting the user.

Looking for feedback on the implementation as well as I need to update the registry-creds repo to handle correctly before merging this in.

Here's a screenshot of what it looks like:

// cc #901 upmc-enterprises/registry-creds#34 @aaron-prindle

minikube-bot · 2017-02-17T18:50:01Z

Can one of the admins verify this patch?

aaron-prindle · 2017-02-17T18:59:47Z

@minikube-bot ok to test

aaron-prindle

Thanks @stevesloka for the PR! I left some comments.

aaron-prindle · 2017-02-22T19:47:34Z

cmd/minikube/cmd/config/prompt.go

@@ -0,0 +1,76 @@
+package config


Can you add the Apache License to the top of this file? We have a test that this is at the top of every .go file in our repo, that's why the travis test is failing. This is the header: https://github.com/kubernetes/minikube/blob/master/pkg/minikube/cluster/cluster.go#L1

aaron-prindle · 2017-02-22T19:57:14Z

cmd/minikube/cmd/config/util.go

+			enableGCR := AskForYesNoConfirmation("\nDo you want to enable Google Container Registry?", posResponses, negResponses)
+			if enableGCR {
+				fmt.Println("-- Enter applicatoin_default_credentials.json as base64 by running following command:")
+				gcrApplicationDefaultCredentials := AskForStaticValue("  base64 -w $HOME/.config/gcloud/application_default_credentials.json: ")


There needs to be a 0 arg in the base64 command, it is base64 -w 0 $HOME/.config/gcloud/application_default_credentials.json. This was a typo I made in the README

aaron-prindle · 2017-02-22T20:12:43Z

cmd/minikube/cmd/config/util.go

+
+				cluster.CreateSecret(
+					"kube-system",
+					"gcr-creds",


The name of the secret that registry-creds look for now is gcr-secret.

aaron-prindle · 2017-02-22T20:13:17Z

cmd/minikube/cmd/config/util.go

+	} else {
+		// Cleanup existing secrets
+		cluster.DeleteSecret("kube-system", "awsecr-creds")
+		cluster.DeleteSecret("kube-system", "gcr-creds")


Same as above.

aaron-prindle · 2017-02-22T21:25:47Z

cmd/minikube/cmd/config/util.go

+				awsRegion := AskForStaticValue("-- Enter AWS Region: ")
+				awsAccount := AskForStaticValue("-- Enter 12 digit AWS Account ID: ")
+
+				cluster.CreateSecret(


I believe that for GCR/ECR to work in registry-creds current state, both secrets will need to be created for the pod to start properly. This was the case in my experience at least. Maybe empty values can be used for secrets specify which mode is enabled? We can also make changes to registry-creds itself.

I'm working on some changes to make this easier, will get back to you when I do. I just finished cleaning up the k8s interfaces and implemented the client-go. Will get back soon!

stevesloka · 2017-02-25T03:59:38Z

Hey @aaron-prindle, I did a bunch of rework on the registry-creds addon. We can now run both registries at the same time. Each cloud gets their own secret.

I can't get GCR to work for me, the credentials don't work. But they also don't match the path you have in the readme. Not sure if my setup is wrong, or something else.

Could you give it a shot? I think the only remaining item I need to add to registry-creds is to watch the secrets in kube-system. What I've found is you enable the addon, then create the secrets, but the addon won't have the correct secrets until the pod is restarted. So I want to make that experience a bit better.

Oh, and for GCR creds, I couldn't get the copy / paste to work. So to avoid all the base64 encode on users machines, just prompted for path on disk. So it reads it from there. Let me know what you think about that.

aaron-prindle · 2017-02-27T05:58:30Z

GCR is working for me on registry-creds:1.6 if I try to build and run it from: https://github.com/upmc-enterprises/registry-creds. It worked after I copied my ~/.config/gcloud/application_default_credentials.json files into the secret.yaml. I did have to run gcloud auth application-default login to get an updated application_default_credentials.json file though in order to pull my GCR image. I was able to pull my private image with it:

apiVersion: v1
kind: Pod
metadata: 
  name: foo
  namespace: default
spec: 
  containers: 
    - image: gcr.io/aprindle-vm-test/hellonode:latest
      name: foo

I definitely agree the ability to watch for a secret would be a great addition instead of having to create the secret prior.

aaron-prindle · 2017-02-27T06:18:56Z

Currently I cannot build the updated version of this addon branch though as there seems to be a build issue with client-go:
https://travis-ci.org/kubernetes/minikube/builds/205196451#L332

aaron-prindle · 2017-02-27T18:31:07Z

This is working for me. It seems there is a boilerplate license issue though:
I believe that the text needs to match exactly the boilerplate of the other files including the newline format:
https://github.com/kubernetes/minikube/blob/master/hack/boilerplate/boilerplate.go.txt
Probably easiest to just copy it directly from another file and keep the newlines.

stevesloka · 2017-02-27T18:32:37Z

@aaron-prindle yeah somehow the spacing was off, just fixed and pushed up now.

codecov-io · 2017-02-27T18:58:54Z

Codecov Report

Merging #1143 into master will decrease coverage by -0.84%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1143      +/-   ##
==========================================
- Coverage   44.86%   44.02%   -0.84%     
==========================================
  Files          47       47              
  Lines        2113     2151      +38     
==========================================
- Hits          948      947       -1     
- Misses       1010     1049      +39     
  Partials      155      155

Impacted Files	Coverage Δ
pkg/minikube/service/service.go	`34.52% <0%> (-10.1%)`	❌
pkg/minikube/kubeconfig/config.go	`55.38% <0%> (-1.54%)`	❌

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bd1b25...50cb1f2. Read the comment docs.

aaron-prindle · 2017-02-27T19:18:52Z

LGTM

googlebot added the cla: yes label Feb 17, 2017

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 17, 2017

aaron-prindle reviewed Feb 22, 2017

View reviewed changes

stevesloka force-pushed the registryCredsPrompt branch 2 times, most recently from c79c116 to 3ec41da Compare February 25, 2017 03:45

stevesloka added 2 commits February 27, 2017 11:09

Allow for addons to prompt for data input

c3d962b

Refactor registry addon

60d9d1e

stevesloka force-pushed the registryCredsPrompt branch from 3ec41da to 60d9d1e Compare February 27, 2017 16:09

Fix go-client / Refactor k8s util code

706d02b

Fix boilerplate

50cb1f2

stevesloka changed the title ~~[WIP] Allow for addons to prompt for data input~~ Allow for addons to prompt for data input Feb 27, 2017

aaron-prindle approved these changes Feb 27, 2017

View reviewed changes

aaron-prindle merged commit 9b539db into kubernetes:master Feb 27, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow for addons to prompt for data input #1143

Allow for addons to prompt for data input #1143

stevesloka commented Feb 17, 2017 •

edited

Loading

minikube-bot commented Feb 17, 2017

aaron-prindle commented Feb 17, 2017

aaron-prindle left a comment

aaron-prindle Feb 22, 2017

aaron-prindle Feb 22, 2017

aaron-prindle Feb 22, 2017 •

edited

Loading

aaron-prindle Feb 22, 2017

aaron-prindle Feb 22, 2017

stevesloka Feb 24, 2017

stevesloka commented Feb 25, 2017 •

edited

Loading

aaron-prindle commented Feb 27, 2017 •

edited

Loading

aaron-prindle commented Feb 27, 2017 •

edited

Loading

aaron-prindle commented Feb 27, 2017

stevesloka commented Feb 27, 2017

codecov-io commented Feb 27, 2017

aaron-prindle commented Feb 27, 2017

Allow for addons to prompt for data input #1143

Allow for addons to prompt for data input #1143

Conversation

stevesloka commented Feb 17, 2017 • edited Loading

minikube-bot commented Feb 17, 2017

aaron-prindle commented Feb 17, 2017

aaron-prindle left a comment

Choose a reason for hiding this comment

aaron-prindle Feb 22, 2017

Choose a reason for hiding this comment

aaron-prindle Feb 22, 2017

Choose a reason for hiding this comment

aaron-prindle Feb 22, 2017 • edited Loading

Choose a reason for hiding this comment

aaron-prindle Feb 22, 2017

Choose a reason for hiding this comment

aaron-prindle Feb 22, 2017

Choose a reason for hiding this comment

stevesloka Feb 24, 2017

Choose a reason for hiding this comment

stevesloka commented Feb 25, 2017 • edited Loading

aaron-prindle commented Feb 27, 2017 • edited Loading

aaron-prindle commented Feb 27, 2017 • edited Loading

aaron-prindle commented Feb 27, 2017

stevesloka commented Feb 27, 2017

codecov-io commented Feb 27, 2017

Codecov Report

aaron-prindle commented Feb 27, 2017

stevesloka commented Feb 17, 2017 •

edited

Loading

aaron-prindle Feb 22, 2017 •

edited

Loading

stevesloka commented Feb 25, 2017 •

edited

Loading

aaron-prindle commented Feb 27, 2017 •

edited

Loading

aaron-prindle commented Feb 27, 2017 •

edited

Loading