assign proper internal IPs for nodes

[sharifelgamal]

This was totally breaking multinode

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-io]

Codecov Report

Merging #8018 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #8018   +/-   ##
=======================================
  Coverage   35.78%   35.78%           
=======================================
  Files         143      143           
  Lines        9174     9171    -3     
=======================================
- Hits         3283     3282    -1     
+ Misses       5490     5489    -1     
+ Partials      401      400    -1     

Impacted Files	Coverage Δ
pkg/minikube/bootstrapper/bsutil/kubelet.go	56.14% <100.00%> (+1.14%)	⬆️

[sharifelgamal]

/ok-to-test

[minikube-pr-bot]

kvm2 Driver
docker Driver

[medyagh]

Did this also fix embed cert issue ? I don't see the failure on this PR. I wonder if that was by chance or you fixed two with one bullet ?

[sharifelgamal]

Did this also fix embed cert issue ? I don't see the failure on this PR. I wonder if that was by chance or you fixed two with one bullet ?

This should have nothing to do with embed-certs, since this is only broken in multinode. I can verify it still fails on this PR as well.

[medyagh]

looks good to me, with required waiting for none tests.

[medyagh]

could the "TestFunctional/parallel/TunnelCmd/serial/AccessDirect" be related to this PR ? could you verify the tunnel test passes on linux locally?

[sharifelgamal]

could the "TestFunctional/parallel/TunnelCmd/serial/AccessDirect" be related to this PR ? could you verify the tunnel test passes on linux locally?

Tunnel works just fine manually on the PR

[aasmall]

Thanks!

 kubectl get nodes -o wide                                   minikube 
NAME           STATUS   ROLES    AGE     VERSION   INTERNAL-IP     EXTERNAL-IP   OS-IMAGE               KERNEL-VERSION   CONTAINER-RUNTIME
minikube       Ready    master   8m7s    v1.18.1   192.168.39.99   <none>        Buildroot 2019.02.10   4.19.107         docker://19.3.8
minikube-m02   Ready    <none>   7m29s   v1.18.1   192.168.39.62   <none>        Buildroot 2019.02.10   4.19.107         docker://19.3.8
minikube-m03   Ready    <none>   7m      v1.18.1   192.168.39.58   <none>        Buildroot 2019.02.10   4.19.107         docker://19.3.8