Skip to content

Commit

Permalink
Merge pull request #8018 from sharifelgamal/nodeip
Browse files Browse the repository at this point in the history
assign proper internal IPs for nodes
  • Loading branch information
medyagh authored May 6, 2020
2 parents f3d5c57 + 464d425 commit 4607c0f
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions pkg/minikube/bootstrapper/bsutil/kubelet.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,8 @@ func extraKubeletOpts(mc config.ClusterConfig, nc config.Node, r cruntime.Manage
if k8s.NetworkPlugin != "" {
extraOpts["network-plugin"] = k8s.NetworkPlugin
}
cp, err := config.PrimaryControlPlane(&mc)
if err != nil {
return nil, errors.Wrap(err, "getting master node")
}
if _, ok := extraOpts["node-ip"]; !ok {
extraOpts["node-ip"] = cp.IP
extraOpts["node-ip"] = nc.IP
}
if _, ok := extraOpts["hostname-override"]; !ok {
nodeName := KubeNodeName(mc, nc)
Expand Down

0 comments on commit 4607c0f

Please sign in to comment.