Skip preload download if --image-repository is set

[prasadkatti]

fixes #7612

[k8s-ci-robot]

Hi @prasadkatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov-io]

Codecov Report

Merging #7707 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #7707   +/-   ##
=======================================
  Coverage   36.48%   36.48%           
=======================================
  Files         147      147           
  Lines        9162     9162           
=======================================
  Hits         3343     3343           
  Misses       5430     5430           
  Partials      389      389           

Impacted Files	Coverage Δ
cmd/minikube/cmd/start_flags.go	50.82% <0.00%> (ø)

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

I dont agree with this PR ! I think if someone is in china we should try to download the preload from github.
we should instead try to upload our preload images to other than GCS bucket but also github

[tstromberg]

I dont agree with this PR ! I think if someone is in china we should try to download the preload from github.
we should instead try to upload our preload images to other than GCS bucket but also github

Yes, and this PR is to address the short-term bleeding for minikube v1.10 - as it's unlikely that we will have images elsewhere before then. Preload leaves man users in China in a broken state, causing an influx of incoming support issues.

Additional thought: If a user sets --image-repository, they want the images to be loaded from a particular location, preloaded or not. Even if we added GitHub, we should still allow a way to respect user preferences.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prasadkatti
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[prasadkatti]

@tstromberg - Added a TODO note as a comment based on your review feedback.

[tstromberg]

/ok-to-test

[minikube-pr-bot]

kvm2 Driver
docker Driver

[minikube-pr-bot]

kvm2 Driver
docker Driver
Times for minikube: [26.771467468 28.088728361999998 27.66955235]
Average time for minikube: 27.509916059999995

Times for Minikube (PR 7707): [26.912649170000005 26.375460907999997 25.082378717]
Average time for Minikube (PR 7707): 26.123496265

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7707) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.0 on           |  0.067742 |                    |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002294 |           0.002208 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.051984 |           0.053844 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.134061 |           7.261222 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000204 |           0.000144 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.458544 |          17.296108 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.727613 |                    |
| components...                          |           |                    |
| * Enabled addons:                      |  0.002500 |           0.002660 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.062305 |           0.059683 |
| configured to use "minikube"           |           |                    |
|                                        |  0.002670 |           0.080305 |
+----------------------------------------+-----------+--------------------+