Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip preload download if --image-repository is set #7612

Closed
chengyayu opened this issue Apr 11, 2020 · 3 comments · Fixed by #7707
Closed

Skip preload download if --image-repository is set #7612

chengyayu opened this issue Apr 11, 2020 · 3 comments · Fixed by #7707
Assignees
@prasadkatti
Labels
co/preload good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. kind/support Categorizes issue or PR as a support question. l/zh-CN Issues in or relating to Chinese priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@chengyayu
Copy link

重现问题所需的命令：minikube start --cpus=2 --memory='2000mb' --vm-driver hyperkit --image-mirror-country='cn' --image-repository='registry.cn-hangzhou.aliyuncs.com/google_containers'

失败的命令的完整输出：


😄 minikube v1.9.2 on Darwin 10.15.4
✨ Using the hyperkit driver based on existing profile
✅ Using image repository registry.cn-hangzhou.aliyuncs.com/google_containers
👍 Starting control plane node m01 in cluster minikube
💾 Downloading Kubernetes v1.18.0 preload ...
> preloaded-images-k8s-v2-v1.18.0-docker-overlay2-amd64.tar.lz4: 131.59 MiB

minikube logs命令的输出：

使用的操作系统版本：macOS 10.15.4
@chengyayu chengyayu added the l/zh-CN Issues in or relating to Chinese label Apr 11, 2020
@lmdkfs
Copy link

lmdkfs commented Apr 11, 2020 •
edited
Loading

我也用到这个 版本了，preloaded image的时候特别慢，最后也失败了

@tstromberg tstromberg added the kind/support Categorizes issue or PR as a support question. label Apr 15, 2020
@tstromberg tstromberg changed the title 重启集群时会重新下载 Kubernetes v1.18.0 preload images Skip preload if --image-repository is set Apr 15, 2020
@tstromberg tstromberg added the kind/bug Categorizes issue or PR as related to a bug. label Apr 15, 2020
@tstromberg tstromberg changed the title Skip preload if --image-repository is set Skip preload download if --image-repository is set Apr 15, 2020
@tstromberg tstromberg mentioned this issue Apr 15, 2020
Open
@tstromberg tstromberg added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. co/preload good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 15, 2020
@tstromberg
Copy link
Contributor

Similarly to image downloads, the preload download is not currently available in China (both are hosted on Google).

We should probably disable the image preload download if a user has specified --image-repository so that it doesn't keep trying to attempt it.

@tstromberg tstromberg mentioned this issue Apr 15, 2020
Closed
@prasadkatti prasadkatti self-assigned this Apr 15, 2020
@prasadkatti prasadkatti mentioned this issue Apr 16, 2020
Merged
@afbjorklund
Copy link
Collaborator

Alternatively, we could provide a similar option for the preload url ? (after #7695)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prasadkatti prasadkatti

Labels
co/preload good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. kind/support Categorizes issue or PR as a support question. l/zh-CN Issues in or relating to Chinese priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip preload download if --image-repository is set prasadkatti/minikube
5 participants
@tstromberg @lmdkfs @prasadkatti @afbjorklund @chengyayu