Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: docker/podman: make soft start 20 seconds faster #7435

Closed
wants to merge 13 commits into from
Prev Previous commit
Next Next commit
fix soft start test
  • Loading branch information
medyagh committed Apr 9, 2020
commit fb908bcc896b214ccaf8024a31a01f44ccace89d
2 changes: 1 addition & 1 deletion pkg/minikube/bootstrapper/kubeadm/kubeadm.go
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ func (k *Bootstrapper) needsReset(conf string, hostname string, port int, client
glog.Infof("needs reset because API server version match : %v", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be reverted. The error made sense already. If not:

needs reset: api version: %v

return true
}
glog.Infof("the %q cluster does not need a reset.", hostname)
glog.Infof("the cluster does not need a reset. hostname: %s", hostname)
return false
}

Expand Down
2 changes: 1 addition & 1 deletion test/integration/start_stop_delete_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func TestStartStop(t *testing.T) {

if !NoneDriver() { // none driver does not invoke needs reset
// if this fails means, our soft start was a hard start.
softLog := "the cluster does not need a reset"
softLog := "cluster does not need a reset"
if !strings.Contains(rr.Output(), softLog) {
t.Errorf("expected the soft start log outputs to include %q but got: %s", softLog, rr.Output())
}
Expand Down