Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: docker/podman: make soft start 20 seconds faster #7435

Closed
wants to merge 13 commits into from
Closed

wip: docker/podman: make soft start 20 seconds faster #7435

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b71035d
disable others in paralel containerd
medyagh Apr 5, 2020
5fad42f
disable others in paralel crio
medyagh Apr 5, 2020
382dddf
disable others in paralel docker
medyagh Apr 5, 2020
98cf66c
add logging for kubeadm needs reset
medyagh Apr 5, 2020
ef5403b
add tests for soft stop
medyagh Apr 5, 2020
b694370
lint
medyagh Apr 5, 2020
1d01be1
lowercase expected word
medyagh Apr 5, 2020
e912175
skip soft start log check for none
medyagh Apr 6, 2020
d28defd
remove paralel disables for another PR to ensure tests
medyagh Apr 6, 2020
70adc95
fix build error
medyagh Apr 8, 2020
fb908bc
fix soft start test
medyagh Apr 9, 2020
7ec6cf8
don't soft test cni case
medyagh Apr 9, 2020
2c435c0
fix build error
medyagh Apr 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
skip soft start log check for none
  • Loading branch information
@medyagh
medyagh committed Apr 9, 2020
commit e912175e24b4784e8198b797c656215e4eebceb5
10 changes: 6 additions & 4 deletions test/integration/start_stop_delete_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,12 @@ func TestStartStop(t *testing.T) {
t.Fatalf("failed to soft start minikube. args %q: %v", rr.Command(), err)
}

// if this fails means, our soft start was a hard start.
softLog := "the cluster does not need a reset"
if !strings.Contains(rr.Output(), softLog) {
t.Errorf("expected the soft start log outputs to include %q but got: %s", softLog, rr.Output())
if !NoneDriver() { // none driver does not invoke needs reset
// if this fails means, our soft start was a hard start.
softLog := "the cluster does not need a reset"
if !strings.Contains(rr.Output(), softLog) {
t.Errorf("expected the soft start log outputs to include %q but got: %s", softLog, rr.Output())
}
}

if !strings.Contains(tc.name, "cni") {
Expand Down